Reservations add protocol version #920
Conversation
sputn1ck
force-pushed
the
reservation_protocol_version
branch
2 times, most recently
from
43642ef to
bfdecb3
Compare
sputn1ck
force-pushed
the
reservation_protocol_version
branch
from
bfdecb3 to
3eab968
Compare
| const ( | ||
| // ProtocolVersionServerInitiated is the protocol version where the | ||
| // server initiates the reservation. | ||
| ProtocolVersionServerInitiated ProtocolVersion = 0 |
There was a problem hiding this comment.
I think we could have a CurrentProtocolVersion function that returns the last one, so we don't need to pass it in when creating a new reservation.
There was a problem hiding this comment.
There is no current as we will still use both simultaneously
There was a problem hiding this comment.
Discussed offline, so the reason to not have is because there will be two current versions, one for the client requested one for the server requested.
| } | ||
|
|
||
| var states fsm.States | ||
| switch reservation.ProtocolVersion { |
There was a problem hiding this comment.
Would be nice to log here which version of the state machine is running. Perhaps also consider adding a String() function to the ProtocolVersion type.
There was a problem hiding this comment.
+1, will do that for the static state machine as well.
| const ( | ||
| // ProtocolVersionServerInitiated is the protocol version where the | ||
| // server initiates the reservation. | ||
| ProtocolVersionServerInitiated ProtocolVersion = 0 |
There was a problem hiding this comment.
Discussed offline, so the reason to not have is because there will be two current versions, one for the client requested one for the server requested.
sputn1ck
force-pushed
the
reservation_protocol_version
branch
from
3eab968 to
8add1f3
Compare
|
@starius: review reminder |
| } | ||
|
|
||
| var states fsm.States | ||
| switch reservation.ProtocolVersion { |
There was a problem hiding this comment.
+1, will do that for the static state machine as well.
sputn1ck
force-pushed
the
reservation_protocol_version
branch
from
8add1f3 to
02f9573
Compare
sputn1ck
force-pushed
the
reservation_protocol_version
branch
from
02f9573 to
56848d0
Compare
4 participants
This PR adds a protocol version to the reservation state machine