Skip to content

Conversation

@guggero
Copy link
Contributor

@guggero guggero commented Apr 23, 2025

Required to build litd with the latest lnd+tapd.

Depends on lightninglabs/taproot-assets#1478.

Not yet ready for merge, since the referenced tapd commit isn't in the main branch yet.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

@guggero guggero force-pushed the lndclient-listchannels branch from fd59dfc to c0c8777 Compare April 24, 2025 09:57
@guggero
Copy link
Contributor Author

guggero commented Apr 24, 2025

Dependent PR in tapd was merged. This is required for lightninglabs/lightning-terminal#987, so going to request review now.

@guggero guggero requested review from bhandras and sputn1ck April 24, 2025 10:03
@guggero
Copy link
Contributor Author

guggero commented Apr 24, 2025

Oops, will fix unit test failures asap.

@guggero guggero force-pushed the lndclient-listchannels branch from c0c8777 to 96f0b08 Compare April 24, 2025 10:38
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Member

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!!!!

Required to build litd with the latest lnd+tapd.
@guggero guggero force-pushed the lndclient-listchannels branch from 96f0b08 to c70dcc5 Compare April 25, 2025 06:38
@guggero guggero merged commit 7e81916 into master Apr 25, 2025
4 checks passed
@guggero guggero deleted the lndclient-listchannels branch April 25, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants