looprpc: fix several minor bugs #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starius
force-pushed
the
fix-protos
branch
2 times, most recently
from
3744dfb to
8a5e649
Compare
sputn1ck
approved these changes
Apr 24, 2025
| The destination address of the withdrawal transaction. | ||
| */ | ||
| string pk_script = 2; | ||
| string address = 2; |
Member
There was a problem hiding this comment.
just a note: this is a breaking change for json clients, but I don't think this is a problem.
Member
There was a problem hiding this comment.
Same, I think it's not a problem atm.
bhandras
approved these changes
Apr 24, 2025
| rpc-check: rpc | ||
| @$(call print, "Verifying protos.") | ||
| if test -n "$$(git describe --dirty | grep dirty)"; then echo "Protos not properly formatted or not compiled with correct version!"; git status; git diff; exit 1; fi | ||
| if test -n "$$(git status --porcelain)"; then echo "Protos not properly formatted or not compiled with correct version!"; git status; git diff; exit 1; fi |
| The destination address of the withdrawal transaction. | ||
| */ | ||
| string pk_script = 2; | ||
| string address = 2; |
Member
There was a problem hiding this comment.
Same, I think it's not a problem atm.
'git describe' may not work in CI because of Git shallow clones. We got false negative of this check: https://github.com/lightninglabs/loop/actions/runs/14556035205/job/40959214856 "fatal: No names found, cannot describe anything."
swapserverrpc/v1.0.11 was force-pushed causing build errors with GOPROXY=direct. Also updated in main go.mod, however it didn't fail, because replace to local dir is used.
GOPROXY=direct is needed to capture the issue with tags force-pushes.
It returns an address, but the field was called pk_script, which was confusing. Also renamed it in the code.
Collaborator
Author
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed field
looprpc.WithdrawDepositsResponse.PkScripttoAddress, because it stores an address, not a pk_script.looprpc was not generated (
make rpc) and CI didn't catch this. Formatted and fixed CI.Also go.mod in
looprpcwas not working if GOPROXY=direct is used. Fixed and added a check to CI.Removed some unneeded renamings of swapserverrpc import to looprpc.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes