mod: add replace directive to compile tapd #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
tapd-migrate-library
branch
from
3be659b to
7e90ade
Compare
Because tapd now uses a fork of the SQL migration library, which can only be used through a replace directive which isn't populated transitively to other dependent projects, we now need to copy that directive to every project.
guggero
force-pushed
the
tapd-migrate-library
branch
from
7e90ade to
0591865
Compare
|
Dependent PR was merged, we now need this to build things in |
sputn1ck
approved these changes
May 2, 2025
Yes, absolutely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this mostly as a reminder and FYI that once lightninglabs/taproot-assets#1198 is in, this
replacedirective will be required fortapdto compile.Because tapd now uses a fork of the SQL migration library, which can only be used through a replace directive which isn't populated transitively to other dependent projects, we now need to copy that directive to every project.