perms: move perms.go into looprpc #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
force-pushed
the
mv-perms-into-looprpc
branch
from
dd21649 to
201a900
Compare
Contributor
Author
|
More changes will be necessary to fix the LNC WASM build issue, but they depend on taproot-assets changes that are not yet merged. |
bhandras
approved these changes
Apr 28, 2025
Member
bhandras
left a comment
bhandras
left a comment
There was a problem hiding this comment.
Changes LGTM 🎉 (still waiting for go mod check to run)
The Lightning Node Connect (LNC) WASM client currently imports both `looprpc` and the entire `loop` module to access `perms.go`. This creates problems because `loop` imports `taproot-assets`, resulting in too many symbols for the WASM build. To fix this, we will move `perms.go`—which defines RPC endpoint permissions—into `looprpc`. After this change, the LNC WASM client will import only `looprpc`, while the rest of `loop` can continue importing `taproot-assets` without affecting the LNC WASM build.
This reverts commit d7d9e2d.
starius
force-pushed
the
mv-perms-into-looprpc
branch
from
201a900 to
7b0c383
Compare
Collaborator
|
I ran |
starius
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall plan and context: lightninglabs/lightning-node-connect#113 (comment)
The Lightning Node Connect (LNC) WASM client currently imports both
looprpcand the entireloopmodule to accessperms.go. This creates problems becauseloopimportstaproot-assets, resulting in too many symbols for the WASM build.To fix this, we will move
perms.go—which defines RPC endpoint permissions—intolooprpc. After this change, the LNC WASM client will import onlylooprpc, while the rest ofloopcan continue importingtaproot-assetswithout affecting the LNC WASM build.