Fix CI #932
Merged
Fix CI #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7b0c383. Access to git.sr.ht/~sbinet/gg was restored, so the check now passes.
bhandras
approved these changes
Apr 29, 2025
| google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 // indirect | ||
| ) | ||
|
|
||
| go 1.18 |
Member
There was a problem hiding this comment.
Why not go directly to 1.23.6 like the main go.mod?
Collaborator
Author
There was a problem hiding this comment.
Somebody may use swapserverrpc externally. They could use an old version of Go. So I decided not to force them to update more than needed.
Protobuf v1.34.2 generates Go files that fail to compile with Go 1.16: predeclared any requires go1.18 or later (-lang was set to go1.16; check go.mod) Also ran "go mod tidy".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI checks were skipped in #931 so the merged version wasn't regenerated.
Also I reinstalled the check of GOPROXY=direct. The broken site
git.sr.ht/~sbinet/ggwas fixed.Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes