liquidity: default to slow swaps for autloop #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
force-pushed
the
autoloop-slow-by-default
branch
from
0c128e7 to
693d3a4
Compare
sputn1ck
approved these changes
Apr 29, 2025
Member
sputn1ck
left a comment
sputn1ck
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick fix
| initiator += "-" + assetSwap.assetID | ||
| } | ||
|
|
||
| var swapPublicationDeadline time.Time |
Member
There was a problem hiding this comment.
I think this should be initialized as time.Now(), as now if you have set FastSwapPublication it will just be time.Time{}
Member
Author
There was a problem hiding this comment.
I think the end-result is the same, we just want something that's presumably in the past. With that in mind the value should not matter and can just be empty for simplicity. wdyt?
Member
There was a problem hiding this comment.
That makes sense, thanks for the explanationj
hieblmi
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes