staticaddr: wait for address manager initiation #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
approved these changes
Jun 12, 2025
sputn1ck
approved these changes
Jun 13, 2025
staticaddr/address/manager.go
Outdated
| } | ||
|
|
||
| // WaitInitComplete waits until the address manager has completed its setup. | ||
| func (m *Manager) WaitInitComplete() { |
Member
There was a problem hiding this comment.
I'd add waiting for a timeout here, either via passing in a context or just listening for a timer here and then returning an error.
We also have a different pattern already
Line 778 in 59f67de
Collaborator
Author
There was a problem hiding this comment.
I went with your suggestion and applied your pattern to all static services. Will also run this over integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a regression that was introduced in 042fe9f by making sure that the address manager is initialized before other managers begin their initialization.
It also applies the init pattern of reservations to staticaddr-managers.