staticaddr: minor fixes #956
Conversation
hieblmi
force-pushed
the
minor-static-fixes
branch
from
5b287c8 to
9f7726a
Compare
staticaddr/deposit/manager.go
Outdated
|
|
||
| numRecoveredDeposits++ | ||
| } | ||
| wg.Wait() |
There was a problem hiding this comment.
I don't think this commit makes sense. If we recover into the action waitforexpirysweptaction this recover will block until the tx is confirmed, making loop unusable for uncertain block times.
There was a problem hiding this comment.
A solution would be to make the action non-blocking (e.g. by moving receiving from the notifiers into a goroutine and sending an event to the fsm)
There was a problem hiding this comment.
Thank you for the catch @sputn1ck. I removed this commit.
hieblmi
force-pushed
the
minor-static-fixes
branch
from
9f7726a to
22266d6
Compare
starius
left a comment
starius
left a comment
There was a problem hiding this comment.
LGTM!
Not sure if the second commit is needed.
|
|
||
| m.activeLoopIns[swapHash] = fsm | ||
| }() | ||
| }(fsm, loopIn.SwapHash) |
There was a problem hiding this comment.
Why is this needed? fsm and swapHash are a local variable and they can't change outside of the goroutine.
There was a problem hiding this comment.
loopIn is a iteration variable which might change before the goroutine launches, so this is needed.
hieblmi
force-pushed
the
minor-static-fixes
branch
from
22266d6 to
80808b6
Compare
hieblmi
force-pushed
the
minor-static-fixes
branch
from
80808b6 to
d526192
Compare
3 participants
depends on #954, ignore first commit