staticaddr: method to fetch deposits by outpoints #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
deposit-outpoint
branch
2 times, most recently
from
5f5780d to
1cc4bbb
Compare
hieblmi
force-pushed
the
deposit-outpoint
branch
from
1cc4bbb to
824ea43
Compare
bhandras
approved these changes
Jun 26, 2025
staticaddr/deposit/manager.go
Outdated
| outpoints []string) ([]*Deposit, error) { | ||
|
|
||
| // Check for duplicates. | ||
| duplicates := make(map[string]struct{}) |
Member
There was a problem hiding this comment.
nit: i'd call this existingOutpoints.
|
|
||
| // DepositsForOutpoints returns all deposits that are behind the given | ||
| // outpoints. | ||
| func (m *Manager) DepositsForOutpoints(ctx context.Context, |
Member
There was a problem hiding this comment.
Where would we use the function? Could you please add coverage?
Collaborator
Author
There was a problem hiding this comment.
Yes sure, it is used to restore deposits of a swap after fetching it from the db, see hieblmi@349b930#diff-2c26627ef62d3f06764cb007a83924ef8abb36066a183b4d05e7f42e7c6a7ac9R23-R283
Ideally this would all be handled by GetLoopInByHash, but it isn't currently.
hieblmi
force-pushed
the
deposit-outpoint
branch
from
824ea43 to
bed8b40
Compare
starius
approved these changes
Jun 27, 2025
staticaddr/deposit/interface.go
Outdated
|
|
||
| // DepositForOutpoint retrieves the deposit with the given outpoint. | ||
| DepositForOutpoint(ctx context.Context, txHash chainhash.Hash, | ||
| idx uint32) (*Deposit, error) |
Collaborator
There was a problem hiding this comment.
I propose to change the signature to more high level:
DepositForOutpoint(ctx context.Context, outpoint string) (*Deposit, error)
staticaddr/deposit/manager.go
Outdated
| outpoints []string) ([]*Deposit, error) { | ||
|
|
||
| // Check for duplicates. | ||
| duplicates := make(map[string]struct{}) |
Collaborator
There was a problem hiding this comment.
I propose to pre-allocate the map. We now the max size.
Comment on lines
+164
to
+178
| row, err := q.DepositForOutpoint(ctx, params) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| latestUpdate, err := q.GetLatestDepositUpdate( | ||
| ctx, row.DepositID, | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } |
Collaborator
There was a problem hiding this comment.
We can do it with SQL join and avoid making an explicit DB transaction (ExecTx).
hieblmi
force-pushed
the
deposit-outpoint
branch
3 times, most recently
from
a3531a9 to
25c90b0
Compare
Collaborator
Author
|
Rebased master |
hieblmi
force-pushed
the
deposit-outpoint
branch
4 times, most recently
from
57d96fc to
5cdb1f7
Compare
hieblmi
force-pushed
the
deposit-outpoint
branch
6 times, most recently
from
c80623f to
613d7a1
Compare
hieblmi
force-pushed
the
deposit-outpoint
branch
from
613d7a1 to
704b9ed
Compare
hieblmi
force-pushed
the
deposit-outpoint
branch
from
704b9ed to
e948c94
Compare
Collaborator
Author
|
Rebased master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds method
DepositsForOutpointsto the deposit manager and required sub-methods to the deposit store.This PR was extracted from and is required by #887 to ease review.