release.sh: fix version matching #965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A commit_hash component was added to the version string: "loop version 0.31.2-beta commit=v0.31.2-beta-dirty commit_hash=xxx". As .* is greedy, it captured "0.31.2-beta commit=v0.31.2-beta-dirty" instead of just "0.31.2-beta". This commit fixes this.
alexbosworth
approved these changes
Jun 18, 2025
hieblmi
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commit_hash component was added to the version string:
As
.*is greedy, it captured "0.31.2-beta commit=v0.31.2-beta-dirty" instead of just "0.31.2-beta".This commit fixes this.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes