staticaddr: simplify withdrawal fsm transition #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
fix-withdraw-test
branch
from
ad23568 to
e145963
Compare
hieblmi
force-pushed
the
fix-withdraw-test
branch
8 times, most recently
from
55da3c1 to
31c9649
Compare
hieblmi
force-pushed
the
fix-withdraw-test
branch
from
31c9649 to
1104e92
Compare
hieblmi
force-pushed
the
fix-withdraw-test
branch
from
55b5671 to
1a30f90
Compare
hieblmi
force-pushed
the
fix-withdraw-test
branch
from
1a30f90 to
1104e92
Compare
hieblmi
force-pushed
the
fix-withdraw-test
branch
2 times, most recently
from
e356cc3 to
a6e4409
Compare
hieblmi
force-pushed
the
fix-withdraw-test
branch
from
a6e4409 to
1104e92
Compare
hieblmi
force-pushed
the
fix-withdraw-test
branch
2 times, most recently
from
c254206 to
8d7da32
Compare
previously upon recovery, a withdrawing deposit was first transitioned into the Deposited state by the deposit manager, and then again into the Withdrawing state by the withdrawal manager. The first transition is unnecessary, so we just remain in the Withdrawing state upon recovery.
hieblmi
force-pushed
the
fix-withdraw-test
branch
from
8d7da32 to
412fe7f
Compare
hieblmi
changed the title
starius
approved these changes
Jul 2, 2025
bhandras
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously upon recovery, a withdrawing deposit was
first transitioned into the Deposited state by the
deposit manager, and then again into the Withdrawing
state by the withdrawal manager. The first transition
is unnecessary, so we just remain in the Withdrawing
state upon recovery.