Skip to content

fee: round up transaction weight to the nearest satoshi #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

fee: round up transaction weight to the nearest satoshi #987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions staticaddr/withdraw/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ func (m *Manager) createWithdrawalTx(ctx context.Context,
if err != nil {
return nil, 0, 0, err
}
feeWithoutChange := feeRate.FeeForWeight(weight)
feeWithoutChange := feeRate.FeeForWeightRoundUp(weight)

// If the user selected a fraction of the sum of the selected deposits
// to withdraw, check if a change output is needed.
Expand All @@ -839,7 +839,7 @@ func (m *Manager) createWithdrawalTx(ctx context.Context,
if err != nil {
return nil, 0, 0, err
}
feeWithChange := feeRate.FeeForWeight(weight)
feeWithChange := feeRate.FeeForWeightRoundUp(weight)

// The available change that can cover fees is the total
// selected deposit amount minus the selected withdrawal amount.
Expand Down