tapdb: only select confirmed assets when funding

To avoid attempting to spend freshly minted assets that haven't been
confirmed yet, we set the minimum anchor height to 1 to avoid selecting
them when funding any transaction.

Author: guggero

tapdb/assets_store.go

@@ -1823,6 +1823,11 @@ func (a *AssetStore) ListEligibleCoins(ctx context.Context,
 	assetFilter.Spent = sqlBool(false)
 	assetFilter.Leased = sqlBool(false)
 
+	// We also only want to select confirmed commitments (freshly minted
+	// unconfirmed assets would otherwise be included). Unconfirmed assets
+	// have a block height of 0, so we set the minimum block height to 1.
+	assetFilter.MinAnchorHeight = sqlInt32(1)
+
 	return a.queryCommitments(ctx, assetFilter)
 }
 

tapdb/assets_store_test.go

@@ -301,6 +301,7 @@ func TestImportAssetProof(t *testing.T) {
 		t, testProof.AssetSnapshot.OutPoint, dbAsset.AnchorOutpoint,
 	)
 	require.Equal(t, testProof.AnchorTx.TxHash(), dbAsset.AnchorTx.TxHash())
+	require.NotZero(t, dbAsset.AnchorBlockHeight)
 
 	// We should also be able to fetch the proof we just inserted using the
 	// script key of the new asset.

tapdb/sqlutils_test.go

@@ -105,7 +105,7 @@ func (d *DbHandler) AddRandomAssetProof(t *testing.T) (*asset.Asset,
 			Asset:             testAsset,
 			OutPoint:          anchorPoint,
 			AnchorBlockHash:   blockHash,
-			AnchorBlockHeight: test.RandInt[uint32](),
+			AnchorBlockHeight: uint32(test.RandIntn(1000) + 1),
 			AnchorTxIndex:     test.RandInt[uint32](),
 			AnchorTx:          anchorTx,
 			OutputIndex:       0,