multi: rename UniverseCommitments field in MintingBatch

Author: ffranr

tapdb/asset_minting.go

@@ -484,7 +484,7 @@ func (a *AssetMintingStore) CommitMintingBatch(ctx context.Context,
 			BatchID:             batchID,
 			HeightHint:          int32(newBatch.HeightHint),
 			CreationTimeUnix:    newBatch.CreationTime.UTC(),
-			UniverseCommitments: newBatch.UniverseCommitments,
+			UniverseCommitments: newBatch.SupplyCommitments,
 		}); err != nil {
 			return fmt.Errorf("unable to insert minting "+
 				"batch: %w", err)
@@ -1298,9 +1298,9 @@ func marshalMintingBatch(ctx context.Context, q PendingAssetStore,
 			},
 			PubKey: batchKey,
 		},
-		HeightHint:          uint32(dbBatch.HeightHint),
-		CreationTime:        dbBatch.CreationTimeUnix.UTC(),
-		UniverseCommitments: dbBatch.UniverseCommitments,
+		HeightHint:        uint32(dbBatch.HeightHint),
+		CreationTime:      dbBatch.CreationTimeUnix.UTC(),
+		SupplyCommitments: dbBatch.UniverseCommitments,
 	}
 
 	batchState, err := tapgarden.NewBatchState(uint8(dbBatch.BatchState))

tapdb/asset_minting_test.go

@@ -94,7 +94,7 @@ func assertBatchEqual(t *testing.T, a, b *tapgarden.MintingBatch) {
 		t, &a.GenesisPacket.FundedPsbt, &b.GenesisPacket.FundedPsbt,
 	)
 	require.Equal(t, a.RootAssetCommitment, b.RootAssetCommitment)
-	require.Equal(t, a.UniverseCommitments, b.UniverseCommitments)
+	require.Equal(t, a.SupplyCommitments, b.SupplyCommitments)
 }
 
 func assertSeedlingBatchLen(t *testing.T, batches []*tapgarden.MintingBatch,
@@ -624,7 +624,7 @@ func TestInsertFetchUniCommitBatch(t *testing.T) {
 		t, tapgarden.WithTotalGroups([]int{1}),
 		tapgarden.WithUniverseCommitments(true),
 	)
-	require.True(t, batch.UniverseCommitments)
+	require.True(t, batch.SupplyCommitments)
 
 	// Generate the group genesis, persist it, and assign the group details
 	// to the seedling.
@@ -655,7 +655,7 @@ func TestInsertFetchUniCommitBatch(t *testing.T) {
 	require.NoError(t, err)
 
 	// Assert that the batch is in the expected state.
-	require.True(t, dbBatch.UniverseCommitments)
+	require.True(t, dbBatch.SupplyCommitments)
 
 	// Assert that the seedling is in the expected state.
 	require.Len(t, dbBatch.Seedlings, 1)
@@ -1925,7 +1925,7 @@ func TestUpsertMintAnchorUniCommitment(t *testing.T) {
 
 	// Create a new batch with one asset group seedling.
 	mintingBatch := tapgarden.RandSeedlingMintingBatch(t, 1)
-	mintingBatch.UniverseCommitments = true
+	mintingBatch.SupplyCommitments = true
 
 	_, _, group := addRandGroupToBatch(
 		t, assetStore, ctx, mintingBatch.Seedlings,

tapgarden/batch.go

@@ -63,13 +63,14 @@ type MintingBatch struct {
 	// reveal for that asset, if it has one.
 	AssetMetas AssetMetas
 
-	// UniverseCommitments is a flag that determines whether the minting
-	// event supports universe commitments. When set to true, the batch must
-	// include only assets that share the same asset group key.
+	// SupplyCommitments is a flag that determines whether the minting
+	// event supports universe supply commitments. When set to true, the
+	// batch must include only assets that share the same asset group key.
 	//
-	// Universe commitments are minter-controlled, on-chain anchored
-	// attestations regarding the state of the universe.
-	UniverseCommitments bool
+	// Universe supply commitments are minter-controlled, on-chain anchored
+	// attestations regarding the state of the universe supply (issued,
+	// ignored, burnt, etc).
+	SupplyCommitments bool
 
 	// mintingPubKey is the top-level Taproot output key that will be used
 	// to commit to the Taproot Asset commitment above.
@@ -110,7 +111,7 @@ func (m *MintingBatch) Copy() *MintingBatch {
 		// set, so a shallow copy is sufficient.
 		BatchKey:            m.BatchKey,
 		RootAssetCommitment: m.RootAssetCommitment,
-		UniverseCommitments: m.UniverseCommitments,
+		SupplyCommitments:   m.SupplyCommitments,
 		mintingPubKey:       m.mintingPubKey,
 		tapSibling:          m.tapSibling,
 	}
@@ -442,14 +443,14 @@ func (m *MintingBatch) validateUniCommitment(newSeedling Seedling) error {
 	// Therefore, when evaluating this new candidate seedling for inclusion
 	// in the batch, we must ensure that its universe commitment flag state
 	// matches the flag state of the batch.
-	if m.UniverseCommitments != newSeedling.SupplyCommitments {
+	if m.SupplyCommitments != newSeedling.SupplyCommitments {
 		return fmt.Errorf("seedling universe commitment flag does " +
 			"not match batch")
 	}
 
 	// If the universe commitment flag is disabled for both the seedling and
 	// the batch, no additional checks are required.
-	if !m.UniverseCommitments && !newSeedling.SupplyCommitments {
+	if !m.SupplyCommitments && !newSeedling.SupplyCommitments {
 		return nil
 	}
 
@@ -459,7 +460,7 @@ func (m *MintingBatch) validateUniCommitment(newSeedling Seedling) error {
 	// * the batch contains at least one seedling.
 	//
 	// For clarity, we will assert these conditions now.
-	if !m.UniverseCommitments || !newSeedling.SupplyCommitments ||
+	if !m.SupplyCommitments || !newSeedling.SupplyCommitments ||
 		!m.HasSeedlings() {
 
 		return fmt.Errorf("unexpected code path reached")
@@ -520,7 +521,7 @@ func (m *MintingBatch) AddSeedling(newSeedling Seedling) error {
 	// seedling being added to the batch, the batch universe commitment flag
 	// can be set to match the seedling's flag state.
 	if !m.HasSeedlings() {
-		m.UniverseCommitments = newSeedling.SupplyCommitments
+		m.SupplyCommitments = newSeedling.SupplyCommitments
 	}
 
 	// Ensure that the delegation key is valid for the seedling being

tapgarden/mock.go

@@ -218,10 +218,10 @@ func RandMintingBatch(t testing.TB, opts ...MintBatchOption) *MintingBatch {
 	// Create an empty minting batch.
 	batchKey, _ := test.RandKeyDesc(t)
 	batch := &MintingBatch{
-		BatchKey:            batchKey,
-		HeightHint:          test.RandInt[uint32](),
-		CreationTime:        time.Now(),
-		UniverseCommitments: options.universeCommitments,
+		BatchKey:          batchKey,
+		HeightHint:        test.RandInt[uint32](),
+		CreationTime:      time.Now(),
+		SupplyCommitments: options.universeCommitments,
 	}
 
 	// Generate seedlings for each asset group.

tapgarden/planter.go

@@ -865,7 +865,7 @@ func fetchPreCommitGroupKey(
 	// If universe commitments are disabled, there is no group key available
 	// from the batch to associate with the pre-commitment. Therefore, we
 	// return None.
-	if !pendingBatch.UniverseCommitments {
+	if !pendingBatch.SupplyCommitments {
 		return zero, nil
 	}
 
@@ -914,7 +914,7 @@ func (c *ChainPlanter) fundGenesisPsbt(ctx context.Context,
 	// If universe commitments are enabled, we formulate a pre-commitment
 	// output. This output is spent by the universe commitment transaction.
 	var delegationKey fn.Option[DelegationKey]
-	if c.pendingBatch != nil && c.pendingBatch.UniverseCommitments {
+	if c.pendingBatch != nil && c.pendingBatch.SupplyCommitments {
 		delegationK, err := fetchDelegationKey(c.pendingBatch)
 		if err != nil {
 			return zero, fmt.Errorf("unable to create "+
@@ -2229,7 +2229,7 @@ func matchPsbtToGroupReq(psbt psbt.Packet,
 // NOTE: The function mutates the supplied *MintingBatch in place.
 func sealBatchPreCommit(batch *MintingBatch) error {
 	// Fast‑exit if Universe Commitments are disabled – nothing to update.
-	if !batch.UniverseCommitments {
+	if !batch.SupplyCommitments {
 		return nil
 	}
 
@@ -2520,7 +2520,7 @@ func (c *ChainPlanter) sealBatch(ctx context.Context, params SealParams,
 	// Persist the newly generated group-key metadata in the batch’s
 	// pre-commitment output—needed only when Universe Commitments are on—
 	// before passing the batch to the minting store.
-	if batchWithGroupInfo.UniverseCommitments {
+	if batchWithGroupInfo.SupplyCommitments {
 		err := sealBatchPreCommit(batchWithGroupInfo)
 		if err != nil {
 			return nil, err