multi: rename UniverseCommitments field in Seedling

Author: ffranr

proof/meta_test.go

@@ -333,7 +333,7 @@ func TestMetaDataRevealEncoding(t *testing.T) {
 				0x4f, 0x4e,
 				// DecDisplay:
 				0x05, 0x04, 0x00, 0x00, 0x00, 0x08,
-				// UniverseCommitments:
+				// SupplyCommitments:
 				0x07, 0x01, 0x01,
 				// CanonicalUniverses:
 				0x09, 0x1e, 0x01, 0x1c, 0x75, 0x6e, 0x69, 0x76,

rpcserver.go

@@ -615,13 +615,13 @@ func (r *rpcServer) MintAsset(ctx context.Context,
 	}
 
 	seedling := &tapgarden.Seedling{
-		AssetVersion:        assetVersion,
-		AssetType:           asset.Type(req.Asset.AssetType),
-		AssetName:           req.Asset.Name,
-		Amount:              req.Asset.Amount,
-		EnableEmission:      req.Asset.NewGroupedAsset,
-		Meta:                &seedlingMeta,
-		UniverseCommitments: req.Asset.EnableSupplyCommitments,
+		AssetVersion:      assetVersion,
+		AssetType:         asset.Type(req.Asset.AssetType),
+		AssetName:         req.Asset.Name,
+		Amount:            req.Asset.Amount,
+		EnableEmission:    req.Asset.NewGroupedAsset,
+		Meta:              &seedlingMeta,
+		SupplyCommitments: req.Asset.EnableSupplyCommitments,
 	}
 
 	rpcsLog.Infof("[MintAsset]: version=%v, type=%v, name=%v, amt=%v, "+

tapdb/asset_minting.go

@@ -552,7 +552,7 @@ func (a *AssetMintingStore) CommitMintingBatch(ctx context.Context,
 				EmissionEnabled: seedling.EnableEmission,
 
 				// nolint: lll
-				UniverseCommitments: seedling.UniverseCommitments,
+				UniverseCommitments: seedling.SupplyCommitments,
 			}
 
 			scriptKeyID, err := upsertScriptKey(
@@ -697,7 +697,7 @@ func (a *AssetMintingStore) AddSeedlingsToBatch(ctx context.Context,
 				EmissionEnabled: seedling.EnableEmission,
 
 				// nolint: lll
-				UniverseCommitments: seedling.UniverseCommitments,
+				UniverseCommitments: seedling.SupplyCommitments,
 			}
 
 			scriptKeyID, err := upsertScriptKey(
@@ -793,8 +793,8 @@ func fetchAssetSeedlings(ctx context.Context, q PendingAssetStore,
 			Amount: uint64(
 				dbSeedling.AssetSupply,
 			),
-			EnableEmission:      dbSeedling.EmissionEnabled,
-			UniverseCommitments: dbSeedling.UniverseCommitments,
+			EnableEmission:    dbSeedling.EmissionEnabled,
+			SupplyCommitments: dbSeedling.UniverseCommitments,
 		}
 
 		if dbSeedling.TweakedScriptKey != nil {

tapdb/asset_minting_test.go

@@ -641,7 +641,7 @@ func TestInsertFetchUniCommitBatch(t *testing.T) {
 
 	// Assert that the seedling is in the expected state.
 	seedling := batch.Seedlings[assetName]
-	require.True(t, seedling.UniverseCommitments)
+	require.True(t, seedling.SupplyCommitments)
 	require.True(t, seedling.DelegationKey.IsSome())
 
 	// Commit the minting batch to the database.
@@ -661,7 +661,7 @@ func TestInsertFetchUniCommitBatch(t *testing.T) {
 	require.Len(t, dbBatch.Seedlings, 1)
 
 	dbSeedling := dbBatch.Seedlings[assetName]
-	require.True(t, dbSeedling.UniverseCommitments)
+	require.True(t, dbSeedling.SupplyCommitments)
 	require.True(t, dbSeedling.DelegationKey.IsSome())
 	require.Equal(t, dbSeedling.DelegationKey, seedling.DelegationKey)
 }

tapgarden/batch.go

@@ -323,7 +323,7 @@ func (m *MintingBatch) HasSeedlings() bool {
 func (m *MintingBatch) validateDelegationKey(newSeedling Seedling) error {
 	// If the universe commitment flag is disabled, then the delegation key
 	// should not be set.
-	if !newSeedling.UniverseCommitments {
+	if !newSeedling.SupplyCommitments {
 		if newSeedling.DelegationKey.IsSome() {
 			return fmt.Errorf("delegation key must not be set " +
 				"for seedling without universe commitments")
@@ -395,7 +395,7 @@ func (m *MintingBatch) validateUniCommitment(newSeedling Seedling) error {
 		// If there are no seedlings in the batch, and the first
 		// (subject) seedling doesn't enable universe commitment, we can
 		// accept it without further checks.
-		if !newSeedling.UniverseCommitments {
+		if !newSeedling.SupplyCommitments {
 			return nil
 		}
 
@@ -442,14 +442,14 @@ func (m *MintingBatch) validateUniCommitment(newSeedling Seedling) error {
 	// Therefore, when evaluating this new candidate seedling for inclusion
 	// in the batch, we must ensure that its universe commitment flag state
 	// matches the flag state of the batch.
-	if m.UniverseCommitments != newSeedling.UniverseCommitments {
+	if m.UniverseCommitments != newSeedling.SupplyCommitments {
 		return fmt.Errorf("seedling universe commitment flag does " +
 			"not match batch")
 	}
 
 	// If the universe commitment flag is disabled for both the seedling and
 	// the batch, no additional checks are required.
-	if !m.UniverseCommitments && !newSeedling.UniverseCommitments {
+	if !m.UniverseCommitments && !newSeedling.SupplyCommitments {
 		return nil
 	}
 
@@ -459,7 +459,7 @@ func (m *MintingBatch) validateUniCommitment(newSeedling Seedling) error {
 	// * the batch contains at least one seedling.
 	//
 	// For clarity, we will assert these conditions now.
-	if !m.UniverseCommitments || !newSeedling.UniverseCommitments ||
+	if !m.UniverseCommitments || !newSeedling.SupplyCommitments ||
 		!m.HasSeedlings() {
 
 		return fmt.Errorf("unexpected code path reached")
@@ -520,7 +520,7 @@ func (m *MintingBatch) AddSeedling(newSeedling Seedling) error {
 	// seedling being added to the batch, the batch universe commitment flag
 	// can be set to match the seedling's flag state.
 	if !m.HasSeedlings() {
-		m.UniverseCommitments = newSeedling.UniverseCommitments
+		m.UniverseCommitments = newSeedling.SupplyCommitments
 	}
 
 	// Ensure that the delegation key is valid for the seedling being

tapgarden/batch_test.go

@@ -147,7 +147,7 @@ func TestValidateUniCommitment(t *testing.T) {
 		t, anchorSeedling.AssetVersion, anchorSeedling.AssetType,
 		anchorSeedling.AssetName, anchorSeedling.Meta.Data,
 		anchorSeedling.DelegationKey,
-		anchorSeedling.UniverseCommitments,
+		anchorSeedling.SupplyCommitments,
 	)
 
 	testCases = append(testCases, TestCase{

tapgarden/mock.go

@@ -89,10 +89,10 @@ func RandGroupAnchorSeedling(t testing.TB, groupAnchorName string,
 			Genesis:  &assetGenesis,
 			GroupKey: groupKey,
 		},
-		ScriptKey:           asset.NewScriptKeyBip86(scriptKey),
-		EnableEmission:      true,
-		UniverseCommitments: uniCommitments,
-		DelegationKey:       delegationKey,
+		ScriptKey:         asset.NewScriptKeyBip86(scriptKey),
+		EnableEmission:    true,
+		SupplyCommitments: uniCommitments,
+		DelegationKey:     delegationKey,
 	}
 }
 
@@ -114,11 +114,11 @@ func RandNonAnchorGroupSeedling(t testing.TB, assetVersion asset.Version,
 		Meta: &proof.MetaReveal{
 			Data: metaDataBlob,
 		},
-		Amount:              uint64(test.RandInt[uint32]()),
-		ScriptKey:           asset.NewScriptKeyBip86(scriptKey),
-		EnableEmission:      true,
-		UniverseCommitments: uniCommitments,
-		DelegationKey:       delegationKey,
+		Amount:            uint64(test.RandInt[uint32]()),
+		ScriptKey:         asset.NewScriptKeyBip86(scriptKey),
+		EnableEmission:    true,
+		SupplyCommitments: uniCommitments,
+		DelegationKey:     delegationKey,
 	}
 	return seedling
 }

tapgarden/planter.go

@@ -2220,7 +2220,7 @@ func matchPsbtToGroupReq(psbt psbt.Packet,
 // packet.
 //
 // Preconditions:
-//   - batch.UniverseCommitments must be true – otherwise the function is a NOP.
+//   - batch.SupplyCommitments must be true – otherwise the function is a NOP.
 //   - batch.GenesisPacket must not be nil.
 //
 // Post‑conditions:
@@ -2711,7 +2711,7 @@ func (c *ChainPlanter) prepSeedlingDelegationKey(ctx context.Context,
 
 	// If the universe commitments feature is disabled for this seedling,
 	// we can skip any further delegation key considerations.
-	if !req.UniverseCommitments {
+	if !req.SupplyCommitments {
 		return nil
 	}
 
@@ -2794,15 +2794,15 @@ func (c *ChainPlanter) prepAssetSeedling(ctx context.Context,
 
 	// If the seedling has the universe/supply commitment feature enabled,
 	// finalize the delegation key.
-	if req.UniverseCommitments {
+	if req.SupplyCommitments {
 		err := c.prepSeedlingDelegationKey(ctx, req)
 		if err != nil {
 			return err
 		}
 	}
 
 	// Set seedling asset metadata fields.
-	req.Meta.UniverseCommitments = req.UniverseCommitments
+	req.Meta.UniverseCommitments = req.SupplyCommitments
 
 	// If a delegation key is set in the seedling, set it in the metadata.
 	if req.DelegationKey.IsSome() {

tapgarden/seedling.go

@@ -94,15 +94,15 @@ type Seedling struct {
 	// for this asset meaning future assets linked to it can be created.
 	EnableEmission bool
 
-	// UniverseCommitments indicates whether the minting event which
-	// will be associated with the seedling supports universe commitments.
+	// SupplyCommitments indicates whether the minting event which
+	// will be associated with the seedling supports supply commitments.
 	// If set to true, the seedling can only be included in a minting batch
 	// where all assets share the same asset group key, which must be
 	// specified.
 	//
-	// Universe commitments are minter-controlled, on-chain anchored
+	// Supply commitments are minter-controlled, on-chain anchored
 	// attestations regarding the state of the universe.
-	UniverseCommitments bool
+	SupplyCommitments bool
 
 	// DelegationKey is the public key that is used to verify universe
 	// commitment related on-chain outputs and proofs.