tapfreighter+tapdb: rename ConfirmParcelDelivery to LogAnchorTxConfirm

This commit renames the ExportLog method from ConfirmParcelDelivery to
LogAnchorTxConfirm. The purpose of this change is to clarify that the
method does not confirm parcel delivery to disk, as transfer proofs may
still be pending. Instead, it updates the send package on disk to
indicate that the transfer anchoring transaction has been confirmed
on-chain.

Author: ffranr

tapdb/assets_store.go

@@ -2809,9 +2809,10 @@ func (a *AssetStore) ConfirmProofDelivery(ctx context.Context,
 	return nil
 }
 
-// ConfirmParcelDelivery marks a spend event on disk as confirmed. This updates
-// the on-chain reference information on disk to point to this new spend.
-func (a *AssetStore) ConfirmParcelDelivery(ctx context.Context,
+// LogAnchorTxConfirm updates the send package state on disk to reflect the
+// confirmation of the anchor transaction, ensuring the on-chain reference
+// information is up to date.
+func (a *AssetStore) LogAnchorTxConfirm(ctx context.Context,
 	conf *tapfreighter.AssetConfirmEvent) error {
 
 	var (

tapdb/assets_store_test.go

@@ -1524,7 +1524,7 @@ func TestAssetExportLog(t *testing.T) {
 	fakeBlockHash := chainhash.Hash(sha256.Sum256([]byte("fake")))
 	blockHeight := int32(100)
 	txIndex := int32(10)
-	err = assetsStore.ConfirmParcelDelivery(
+	err = assetsStore.LogAnchorTxConfirm(
 		ctx, &tapfreighter.AssetConfirmEvent{
 			AnchorTXID:  firstOutputAnchor.OutPoint.Hash,
 			TxIndex:     txIndex,

tapfreighter/chain_porter.go

@@ -650,7 +650,7 @@ func (p *ChainPorter) storePackageAnchorTxConf(pkg *sendPackage) error {
 	// parcel delivery as completed in the database.
 	anchorTXID := pkg.OutboundPkg.AnchorTx.TxHash()
 	anchorTxBlockHeight := int32(pkg.TransferTxConfEvent.BlockHeight)
-	err := p.cfg.ExportLog.ConfirmParcelDelivery(ctx, &AssetConfirmEvent{
+	err := p.cfg.ExportLog.LogAnchorTxConfirm(ctx, &AssetConfirmEvent{
 		AnchorTXID:             anchorTXID,
 		BlockHash:              *pkg.TransferTxConfEvent.BlockHash,
 		BlockHeight:            anchorTxBlockHeight,

tapfreighter/interface.go

@@ -421,10 +421,10 @@ type ExportLog interface {
 	// transferred.
 	ConfirmProofDelivery(context.Context, wire.OutPoint, uint64) error
 
-	// ConfirmParcelDelivery marks a spend event on disk as confirmed. This
-	// updates the on-chain reference information on disk to point to this
-	// new spend.
-	ConfirmParcelDelivery(context.Context, *AssetConfirmEvent) error
+	// LogAnchorTxConfirm updates the send package state on disk to reflect
+	// the confirmation of the anchor transaction, ensuring the on-chain
+	// reference information is up to date.
+	LogAnchorTxConfirm(context.Context, *AssetConfirmEvent) error
 
 	// QueryParcels returns the set of confirmed or unconfirmed parcels.
 	QueryParcels(ctx context.Context, anchorTxHash *chainhash.Hash,