Skip to content

Conversation

@guggero
Copy link
Contributor

@guggero guggero commented May 20, 2025

Fixes lightninglabs/lightning-terminal#1075 (review).

If the user specifies sats but we end up setting the (validated) mSat amount, we run into the error "sat and msat arguments are mutually exclusive" in lnd.
To fix that, we need to reset the sat value.

If the user specifies sats but we end up setting the (validated) mSat
amount, we run into the error "sat and msat arguments are mutually
exclusive" in lnd.
To fix that, we need to reset the sat value.
@guggero guggero requested a review from GeorgeTsagk May 20, 2025 07:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15131569386

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 15 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 36.812%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
commitment/tap.go 1 72.05%
address/address.go 2 67.47%
tapchannel/aux_leaf_signer.go 2 43.08%
tapdb/universe.go 4 80.35%
tapgarden/caretaker.go 6 68.68%
Totals Coverage Status
Change from base Build 15055985108: 0.01%
Covered Lines: 26519
Relevant Lines: 72039

💛 - Coveralls

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@guggero guggero requested a review from ffranr May 20, 2025 08:58
@ffranr ffranr added this pull request to the merge queue May 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2025
@guggero guggero merged commit 97c53cc into main May 20, 2025
18 checks passed
@guggero guggero deleted the invoice-amt branch May 20, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants