Skip to content

Conversation

@guggero
Copy link
Contributor

@guggero guggero commented Jun 17, 2025

Fixes an issue where attempting to pay a below-dust carrier HTLC satoshi amount would knock a channel offline.

Found after attempting the negative test mentioned here: lightninglabs/lightning-terminal#1089 (comment)
Nice catch, @GeorgeTsagk.

@guggero guggero requested review from GeorgeTsagk and ffranr June 17, 2025 07:59
@guggero guggero force-pushed the keysend-min-amount branch from 3243db8 to 6a4c25a Compare June 17, 2025 09:10
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🧮

@coveralls
Copy link

coveralls commented Jun 17, 2025

Pull Request Test Coverage Report for Build 15710061227

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 22 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+18.6%) to 55.856%

Files with Coverage Reduction New Missed Lines %
address/mock.go 2 86.93%
asset/asset.go 2 80.06%
commitment/tap.go 2 84.77%
asset/mock.go 3 72.62%
tapchannel/aux_leaf_signer.go 3 43.43%
tapgarden/caretaker.go 4 78.15%
tapdb/multiverse.go 6 82.23%
Totals Coverage Status
Change from base Build 15693890710: 18.6%
Covered Lines: 53069
Relevant Lines: 95010

💛 - Coveralls

Fixes an issue where attempting to pay a below-dust carrier HTLC satoshi
amount would knock a channel offline.
@guggero guggero force-pushed the keysend-min-amount branch from 6a4c25a to 3696ead Compare June 17, 2025 14:27
@guggero guggero enabled auto-merge June 17, 2025 14:28
@guggero guggero added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 485073b Jun 17, 2025
35 of 36 checks passed
@guggero guggero deleted the keysend-min-amount branch June 17, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants