Invoice manager tolerance tweaks #1673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how does this differ from #1639 ? |
Pull Request Test Coverage Report for Build 17449019071Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
above adds a single 1 unit per invoice on the tolerance This approach adds N msats, where N is the number of HTLCs paying to this invoice |
GeorgeTsagk
force-pushed
the
invoice-tolerance-tweaks
branch
from
b8ece69 to
343b196
Compare
jtobin
approved these changes
Aug 26, 2025
|
@ffranr: review reminder |
Roasbeef
approved these changes
Sep 3, 2025
| // allows for a total error that scales with the number of | ||
| // shards. We go up to numHTLCS-1 because we want to add any | ||
| // leftovers to the last shard. | ||
| for range numHTLCs - 1 { |
There was a problem hiding this comment.
Heh, I always forget that we have this new range syntax to just do a simple loop N times.
github-project-automation
bot
moved this from 🏗 In progress
to 👀 In review
in Taproot-Assets Project Board
We slightly bump the rapid test range for the asset rate, in order to allow for 1 asset unit to evaluate to much less than 1msat. This exposes some of the rounding errors causing errors in the rapid test (it fails if you run it on this commit).
We update the tolerance model in the rapid test to account for 1 unit plus 1 msat, both per HTLC.
Roasbeef
force-pushed
the
invoice-tolerance-tweaks
branch
from
469f2e1 to
4df245b
Compare
|
tacked on a commit with release notes |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First commit exposes our current tolerance, leading to new rounding errors.
There was also an inaccuracy in the way we sharded the amount across the number of HTLCs. We had to also carry the remainder of
invoiceAmt / numHTLCs, which is currently added to the last shard.Then we modify the tolerance model to instead be
(1unit + 1msat)*numHTLCsLet's use this topology to put things in order
Dave creates an asset invoice, Alice pays to it (with
NHTLCs)N unitsof toleranceN msatsof toleranceThe current rapid test tolerance model follows the above model and seems to be happy (for
rapid.checksup to 10M)