Feature bits #1748
Open
Feature bits #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Aug 19, 2025
GeorgeTsagk
force-pushed
the
feature-bits
branch
2 times, most recently
from
eb267a6 to
77f9420
Compare
Pull Request Test Coverage Report for Build 17382758755Details
💛 - Coveralls |
jtobin
reviewed
Aug 29, 2025
GeorgeTsagk
force-pushed
the
feature-bits
branch
from
77f9420 to
74d98bf
Compare
jtobin
reviewed
Sep 2, 2025
| @@ -125,13 +127,23 @@ type AssetSalePolicy struct { | |||
| // wants us to produce NoOp HTLCs. | |||
| NoOpHTLCs bool | |||
There was a problem hiding this comment.
Can anything pathological happen if we register an AssetSalePolicy with NoOpHTLCs enabled/disabled, but then restart with NoOpHTLCs disabled/enabled before the policy expires?
| @@ -125,13 +127,23 @@ type AssetSalePolicy struct { | |||
| // wants us to produce NoOp HTLCs. | |||
| NoOpHTLCs bool | |||
|
|
|||
| // auxChannelNegotiator is used to query the supported feature bits that | |||
| // are supported by a peer, or a channel. | |||
| auxChanNegotiator *tapfeatures.AuxChannelNegotiator | |||
There was a problem hiding this comment.
Revisiting: see my PR to this branch for a potential alternative way to handle this.
| func NewAssetSalePolicy(quote rfqmsg.BuyAccept, noop bool) *AssetSalePolicy { | ||
| func NewAssetSalePolicy(quote rfqmsg.BuyAccept, noop bool, | ||
| chanNegotiator *tapfeatures.AuxChannelNegotiator, | ||
| peer route.Vertex) *AssetSalePolicy { |
There was a problem hiding this comment.
I think the 'peer' argument here is unnecessary, as it can be gotten from quote.Peer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the necessary subsystem to handle custom feature bit negotiation for tap channels. This allows us to introduce new channel features that would otherwise break backwards compatibility. We piggy-back on the existing LND messages (init & reestablish) to nest the
tlv.Blobthat encodes theCustomChannelType(uint64) type.The set of active features over a channel is the intersection of the locally supported features and the features that the peer provided.
Currently we follow a "global" approach on the feature bits that we support. We don't make any distinctions between peers or channels. The locally supported feature bits is a static set.
We also don't allow reading/writing feature bits per channel, but per peer. For now the funding outpoint / funding blob arguments are ignored. When we establish a feature-set with a peer, that applies to all of our channels with that peer.
An older tapd node (i.e a node that does not contain the contents of this PR) will be treated as if they provided an empty feature set (
uint64with0's)Dependencies
LND lightningnetwork/lnd#10182
Lndclient lightninglabs/lndclient#239
LiT itest: lightninglabs/lightning-terminal#1138