Skip to content

Conversation

guggero
Copy link
Contributor

@guggero guggero commented Aug 21, 2025

Adds more unit tests around the commitment v0/v1/v2 formats.

Adds unit tests for the commitment v2 format.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17121949593

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • 85 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.641%

Files with Coverage Reduction New Missed Lines %
authmailbox/receive_subscription.go 1 79.25%
address/mock.go 2 95.11%
commitment/tap.go 2 85.19%
tapdb/sqlc/transfers.sql.go 2 82.65%
tapdb/universe.go 2 81.64%
universe/syncer.go 2 82.73%
asset/asset.go 3 80.15%
asset/mock.go 3 73.21%
itest/multisig.go 3 97.94%
tapchannel/aux_leaf_signer.go 3 43.43%
Totals Coverage Status
Change from base Build 17057360543: -0.02%
Covered Lines: 60687
Relevant Lines: 107143

💛 - Coveralls

@levmi levmi moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Aug 21, 2025
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥓

@Roasbeef Roasbeef merged commit cfd0ef3 into main Sep 4, 2025
18 of 19 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants