Skip to content

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Aug 28, 2025

Assign a separate minting store to each test case to avoid shared state and improve test reliability.

I think I've noticed this unit test flake a few times in CI.

Assign a separate minting store to each test case to avoid shared
state and improve test reliability.
@ffranr ffranr requested review from jtobin and GeorgeTsagk August 28, 2025 16:10
@ffranr ffranr self-assigned this Aug 28, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17301563467

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+8.0%) to 56.683%

Files with Coverage Reduction New Missed Lines %
fn/context_guard.go 1 91.94%
tapdb/mssmt.go 2 89.55%
tapgarden/custodian.go 2 77.02%
itest/multisig.go 3 97.49%
itest/assertions.go 6 88.93%
mssmt/compacted_tree.go 6 77.97%
tapdb/assets_store.go 7 79.29%
Totals Coverage Status
Change from base Build 17301129198: 8.0%
Covered Lines: 61025
Relevant Lines: 107661

💛 - Coveralls

Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM.

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ffranr ffranr added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 8b04ad8 Sep 3, 2025
54 of 57 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants