fn: fix loop var capture and clarify naming in ParSliceErrCollect
#1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17325825267Details
💛 - Coveralls |
jtobin
reviewed
Aug 29, 2025
Roasbeef
reviewed
Aug 29, 2025
ffranr
force-pushed
the
parslice-capture-naming
branch
from
da6a600 to
4452a12
Compare
Ensure each goroutine captures its own index/value in ParSliceErrCollect, and rename variables for clearer intent. Avoids closure capture bug and makes concurrency guards explicit. Add explicit context cancellation handling so the function returns a partial error map along with a non-nil error when the caller's context is canceled or times out.
ffranr
force-pushed
the
parslice-capture-naming
branch
from
4452a12 to
f0ea040
Compare
ffranr
requested review from
Roasbeef and
gijswijs
and removed request for
GeorgeTsagk
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure each goroutine captures its own index/value in
ParSliceErrCollect, and rename variables for clearer intent. Avoids closure capture bug and makes concurrency guards explicit.