rfqrpc+rpcserver: fix peer_pub_key doc and simplify comments #1774
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove misleading "optional" wording from the `peer_pub_key` field comments in BuyOrderRequest and SellOrderRequest proto messages. The updated comments now accurately describe the field as required.
Simplify comments in the RPC server code and correct an error where a comment incorrectly referred to a buy order instead of a sell order.
ffranr
added
bug
Pull Request Test Coverage Report for Build 17310845791Details
💛 - Coveralls |
GeorgeTsagk
approved these changes
Sep 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1773
This PR updates documentation and comments for RFQ order handling:
rfqrpc:
peer_pub_keyfield comments inBuyOrderRequestandSellOrderRequestto reflect that the field is required, removing the misleading "optional" wording.rpcserver:
See also: #1773 (comment)