Skip to content

build: update CI+release version to Go 1.25.2 #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: update CI+release version to Go 1.25.2 #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ env:
# go needs absolute directories, using the $HOME variable doesn't work here.
GOPATH: /home/runner/work/go

GO_VERSION: '1.24.6'
GO_VERSION: '1.25.2'

LITD_ITEST_BRANCH: 'tapd-main-branch'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ defaults:
shell: bash

env:
GO_VERSION: 1.24.6
GO_VERSION: 1.25.2

jobs:
main:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6-alpine as builder
FROM golang:1.25.2-alpine as builder

# Force Go to use the cgo based DNS resolver. This is required to ensure DNS
# queries required to connect to linked containers succeed.
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ DOCKER_TOOLS = docker run \
-v $(shell bash -c "mkdir -p /tmp/go-lint-cache; echo /tmp/go-lint-cache"):/root/.cache/golangci-lint \
-v $$(pwd):/build taproot-assets-tools

GO_VERSION = 1.24.6
GO_VERSION = 1.25.2

GREEN := "\\033[0;32m"
NC := "\\033[0m"
Expand Down
2 changes: 1 addition & 1 deletion dev.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6 as builder
FROM golang:1.25.2 as builder

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion docs/examples/basic-price-oracle/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module basic-price-oracle

go 1.24.6
go 1.24.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 1.25.2 also?


// We want to format raw bytes as hex instead of base64. The forked version
// allows us to specify that as an option.
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/lightninglabs/taproot-assets

go 1.24.6
go 1.24.8

require (
github.com/btcsuite/btcd v0.24.3-0.20250318170759-4f4ea81776d6
Expand Down
2 changes: 1 addition & 1 deletion itest/loadtest/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6 as builder
FROM golang:1.25.2 as builder

WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion make/builder.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6-bookworm
FROM golang:1.25.2-bookworm

MAINTAINER Olaoluwa Osuntokun <[email protected]>

Expand Down
2 changes: 1 addition & 1 deletion taprpc/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6-bookworm
FROM golang:1.25.2-bookworm

RUN apt-get update && apt-get install -y \
git \
Expand Down
2 changes: 1 addition & 1 deletion taprpc/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/lightninglabs/taproot-assets/taprpc

go 1.24.6
go 1.24.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump this to 1.25.2 also? The linter might fail.
Same for tools/go.mod

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically make sure we support building with the last two Go versions. Changing this would mean you can't build with Go 1.24.


require (
github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0
Expand Down
2 changes: 1 addition & 1 deletion tools/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.24.6-bookworm
FROM golang:1.25.2-bookworm

RUN apt-get update && apt-get install -y git
ENV GOCACHE=/tmp/build/.cache
Expand Down
2 changes: 1 addition & 1 deletion tools/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/lightninglabs/taproot-assets/tools

go 1.24.6
go 1.24.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating the Go version, it's a good opportunity to synchronize dependencies with the root go.mod. This file uses btcd v0.24.2, while the root go.mod uses a newer version (v0.24.3-0...). Using outdated dependencies for development tools can sometimes lead to incorrect analysis. Please consider running go get -u and go mod tidy in the tools directory to align the dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point here for the tools.


require (
github.com/btcsuite/btcd v0.24.2
Expand Down
Loading