feat: RFQ forward history accounting and query API #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
darioAnongba
force-pushed
the
feat/forward-history
branch
2 times, most recently
from
26178d0 to
5e71beb
Compare
Pull Request Test Coverage Report for Build 20822584845Details
💛 - Coveralls |
darioAnongba
force-pushed
the
feat/forward-history
branch
from
5e71beb to
ecf9c3e
Compare
darioAnongba
force-pushed
the
feat/forward-history
branch
2 times, most recently
from
72a580d to
acff712
Compare
|
@jtobin: review reminder |
darioAnongba
force-pushed
the
feat/forward-history
branch
2 times, most recently
from
75f3c39 to
5769d7d
Compare
Roasbeef
requested changes
Jan 7, 2026
| payReq := ts.CarolLnd.RPC.DecodePayReq(invoice.PaymentRequest) | ||
|
|
||
| // Construct route: Alice -> Bob -> Carol. | ||
| routeBuildResp := ts.AliceLnd.RPC.BuildRoute( |
Member
There was a problem hiding this comment.
Why not just use normal invoices here? Would make the test a bit simpler as then you just make the invoice and all the RFQ related stuff is handled.
darioAnongba
force-pushed
the
feat/forward-history
branch
2 times, most recently
from
5412e68 to
db0a707
Compare
darioAnongba
force-pushed
the
feat/forward-history
branch
from
db0a707 to
77ab82a
Compare
Adds a new rfq_forwards table migration with its associated models and queries: - Query forwards with filters - Count forwards
darioAnongba
force-pushed
the
feat/forward-history
branch
from
77ab82a to
bac969d
Compare
- Adds the forward store in the DB layer. - Moves business entities from the DB layer to the RFQ layer. - Defines Forward Store interface and entities.
On settle event from LND, log the RFQ forward event into the DB.
with pagination and filters.
Reconciliates the state of pending forwards on startup by verifying their status on LND: - if failed or settled, update the state - if still pending, populate the caches
darioAnongba
force-pushed
the
feat/forward-history
branch
from
bac969d to
e86d49f
Compare
darioAnongba
requested review from
GeorgeTsagk and
Roasbeef
and removed request for
ffranr and
jtobin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RFQ forward history tracking, allowing edge nodes to monitor and query their asset forwarding activity and fee revenue. Edge nodes need visibility into their RFQ forwarding activity to:
Changes
rfq_forwardstable to store forward eventsQueryRfqForwards: New RPC endpointtapcli rfqrpc forwards: Query forward history from CLI with filters--min-timestamp,--max-timestamp,--peer,--asset-id,--group-key,--limit,--offsetFixes #1005