bugfix error matching sweeper #10189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go.mod
Outdated
|
|
||
| retract v0.0.2 | ||
|
|
||
| replace github.com/btcsuite/btcwallet => github.com/ziggie1984/btcwallet v0.16.10-0.20250902074924-f9f0dabe6fbd |
There was a problem hiding this comment.
I lack experience with this in lnd, but are we ok with merging replaces to local forks to lnd master?
Roasbeef
requested changes
Sep 2, 2025
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
fcb4fba to
78c6696
Compare
ViktorTigerstrom
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
Awesome, thanks for the changes 🎉! LGTM, though I'm lacking the context of @Roasbeef, so not sure if #10189 (comment) should be addressed.
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
78c6696 to
0b7074c
Compare
When overlay channels are used the extra output needs to be considered.
ziggie1984
force-pushed
the
fix-fee-estimation
branch
from
0b7074c to
5661ca3
Compare
|
Verified on LITD and this approach fixes the bug ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
btcsuite/btcwallet#1053
Fixes:
lightninglabs/taproot-assets#1770
and
lightninglabs/lightning-terminal#1139 (which needs to bump the corresponding LND version if this is merged.)