-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Part 2|*] Implement First Part for SQL Backend functions #10287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ziggie1984
wants to merge
6
commits into
lightningnetwork:elle-payment-sql-series-new
Choose a base branch
from
ziggie1984:introduce-sql-schema-payments-part-2
base: elle-payment-sql-series-new
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
18f03ec
sqldb: add index and comment to payment tables
ziggie1984 c908b52
multi: add relevant queries for QueryPayments implemenation
ziggie1984 52d466f
paymentsdb: add new internal error
ziggie1984 353160c
paymentsdb: implement QueryPayments for sql backend
ziggie1984 fc4ce67
paymentsdb: implement FetchPayment for sql backend
ziggie1984 0849296
docs: add release-notes
ziggie1984 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,13 @@ package paymentsdb | |
|
|
||
| import ( | ||
| "context" | ||
| "database/sql" | ||
| "errors" | ||
| "fmt" | ||
| "math" | ||
| "time" | ||
|
|
||
| "github.com/lightningnetwork/lnd/lntypes" | ||
| "github.com/lightningnetwork/lnd/lnwire" | ||
| "github.com/lightningnetwork/lnd/sqldb" | ||
| "github.com/lightningnetwork/lnd/sqldb/sqlc" | ||
|
|
@@ -474,3 +476,40 @@ func (s *SQLStore) QueryPayments(ctx context.Context, | |
| TotalCount: uint64(totalCount), | ||
| }, nil | ||
| } | ||
|
|
||
| // FetchPayment fetches the payment corresponding to the given payment | ||
| // hash. | ||
| // | ||
| // This is part of the DB interface. | ||
| func (s *SQLStore) FetchPayment(paymentHash lntypes.Hash) (*MPPayment, error) { | ||
| ctx := context.TODO() | ||
|
|
||
| var mpPayment *MPPayment | ||
|
|
||
| err := s.db.ExecTx(ctx, sqldb.ReadTxOpt(), func(db SQLQueries) error { | ||
| dbPayment, err := db.FetchPayment(ctx, paymentHash[:]) | ||
| if err != nil && !errors.Is(err, sql.ErrNoRows) { | ||
| return fmt.Errorf("failed to fetch payment: %w", err) | ||
| } | ||
|
|
||
| if errors.Is(err, sql.ErrNoRows) { | ||
| return ErrPaymentNotInitiated | ||
| } | ||
|
|
||
| mpPayment, err = s.fetchPaymentWithCompleteData( | ||
| ctx, db, dbPayment, | ||
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to fetch payment with "+ | ||
| "complete data: %w", err) | ||
| } | ||
|
|
||
| return nil | ||
| }, func() { | ||
| }) | ||
|
Comment on lines
+508
to
+509
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sqldb.NoOpReset |
||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to fetch payment: %w", err) | ||
| } | ||
|
|
||
| return mpPayment, nil | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.