Skip to content

Improve lncli closechannel error messages for mempool fee and channel state (#9155) #10288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve lncli closechannel error messages for mempool fee and channel state (#9155) #10288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e29a23
Improve lncli closechannel error messages for mempool fee and channel…
Suvrat1629 Oct 13, 2025
469e373
Fix styling
Suvrat1629 Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lnwallet/btcwallet/btcwallet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,11 @@ func mapRpcclientError(err error) error {
case errors.Is(err, chain.ErrMempoolMinFeeNotMet),
errors.Is(err, chain.ErrMinRelayFeeNotMet):

return fmt.Errorf("%w: %v", lnwallet.ErrMempoolFee, err.Error())
return fmt.Errorf("%w: %v. The cooperative close transaction " +
"was created but not accepted into the mempool due to low " +
"fees. You may need to use 'lncli wallet bumpfee' to increase "+
"the fee and get the transaction confirmed",
lnwallet.ErrMempoolFee, err.Error())
}

return err
Expand Down
15 changes: 13 additions & 2 deletions rpcserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2853,9 +2853,20 @@ func (r *rpcServer) CloseChannel(in *lnrpc.CloseChannelRequest,
"offline channel with chan_point=%v",
chanPoint)

// Check if the channel is already closed or has a pending close tx.
if channel.HasChanStatus(
channeldb.ChanStatusCoopBroadcasted) {
return fmt.Errorf("channel is already " +
"in the process of closing. Check " +
"'lncli pendingchannels' for status. " +
"If the close transaction is not " +
"confirmed, you may need to use " +
"'lncli wallet bumpfee'")
}

return fmt.Errorf("unable to gracefully close "+
"channel while peer is offline (try "+
"force closing it instead): %v", err)
"channel while peer is offline " +
"(try force closing it instead): %v", err)
}
}

Expand Down