[Part 6|*] Thread Contexts through payment methods Part 2 #10308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we add all queries which we will need to insert payment related data into the db.
In commit add the harness which will be used to run db agnostic tests against the kv and sql backend. However it does not use it in this commit but it will over the next commits enable these db agnostic tests for the relevant test functions.
Since now the sql backend is more strict in using the same session key we refactor the helper so that we can easily change the session key for every new attempt.
We make the QueryPayments test db agnostic and also keep a small test for querying the duplicate payments case in the kv world.
Now that every method of the interface was implemented we can remove the embedded reference to the KVStore.
We now test every test in the payment_test.go file against all databases.
ziggie1984
changed the base branch from
master
to
elle-payment-sql-series-new
6 tasks
A context is added to failPaymentAndAttempt and its dependant function calls.
ziggie1984
force-pushed
the
introduce-sql-schema-payments-part-6
branch
from
d78c447 to
7e67836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of the Context Threading refactor. Depends on #10307