-
Couldn't load subscription status.
- Fork 2.2k
multi: add DeleteForwardingEvents to selectively purge old forwarding history #10319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Roasbeef
wants to merge
10
commits into
lightningnetwork:master
Choose a base branch
from
Roasbeef:fwd-history-purge
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8417f4b
channeldb: add DeleteForwardingEvents method for privacy
Roasbeef f61959b
channeldb/test: add comprehensive tests for event deletion
Roasbeef 3da9e6a
routerrpc: add DeleteForwardingHistory RPC definition
Roasbeef 9ebe03d
routerrpc: regenerate RPC stubs for DeleteForwardingHistory
Roasbeef e6ed506
routerrpc: implement DeleteForwardingHistory RPC handler
Roasbeef 012d94c
lntest: add DeleteForwardingHistory to test harness
Roasbeef da2ad05
rpcserver: wire ForwardingLog to router backend
Roasbeef 115a78d
cmd: add deletefwdhistory CLI command
Roasbeef 26aa649
itest: add comprehensive integration tests for deletion
Roasbeef 017299f
docs: add comprehensive privacy guide for forwarding history
Roasbeef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function comment states that it deletes events "older than"
endTime. However, the implementation and tests show that it deletes events with a timestamp less than or equal toendTime. To avoid confusion, it would be clearer to state that it deletes events "at or before" the specifiedendTime.