Skip to content

multi: rename experimental endorsement signal to accountable #10367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elnosh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

multi: rename experimental endorsement signal to accountable #10367

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8a8293
multi: rename experimental endorsement signal to accountable
elnosh Nov 12, 2025
73d1e41
server: remove accountability signal experiment period
elnosh Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/release-notes/release-notes-0.21.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@
This applies to both funders and fundees, with the ability to override the
value during channel opening or acceptance.

* Rename [experimental endorsement signal](https://github.com/lightning/blips/blob/a833e7b49f224e1240b5d669e78fa950160f5a06/blip-0004.md)
to [accountable](https://github.com/lightningnetwork/lnd/pull/10367) to match
the latest [proposal](https://github.com/lightning/blips/pull/67).

## RPC Updates

## lncli Updates
Expand Down
2 changes: 0 additions & 2 deletions htlcswitch/link.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3346,8 +3346,6 @@ func (l *channelLink) processRemoteAdds(fwdPkg *channeldb.FwdPkg) {
func (l *channelLink) experimentalAccountability(
customUpdateAdd record.CustomSet) fn.Option[byte] {

// Only relay experimental signal if we are within the experiment
// period.
if !l.cfg.ShouldFwdExpAccountability() {
return fn.None[byte]()
}
Expand Down
8 changes: 1 addition & 7 deletions rpcserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,13 +775,7 @@ func (r *rpcServer) addDeps(ctx context.Context, s *server,
return nil
},
ShouldSetExpAccountability: func() bool {
if s.cfg.ProtocolOptions.NoExpAccountability() {
return false
}

return clock.NewDefaultClock().Now().Before(
AccountabilityExperimentEnd,
)
return !s.cfg.ProtocolOptions.NoExpAccountability()
},
}

Expand Down
14 changes: 1 addition & 13 deletions server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,6 @@ var (
// TODO(roasbeef): add command line param to modify.
MaxFundingAmount = funding.MaxBtcFundingAmount

// AccountabilityExperimentEnd is the time after which nodes should stop
// propagating experimental accountable signals.
//
// Per blip04: January 1, 2026 12:00:00 AM UTC in unix seconds.
AccountabilityExperimentEnd = time.Unix(1767225600, 0)
Copy link
Member

@Roasbeef Roasbeef Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here?

Copy link
Author

@elnosh elnosh Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the experiment dates will be removed since the default signal is changing to be same for both senders and forwarding nodes. Added a commit msg explaining why it was removed :)


// ErrGossiperBan is one of the errors that can be returned when we
// attempt to finalize a connection to a remote peer.
ErrGossiperBan = errors.New("gossiper has banned remote's key")
Expand Down Expand Up @@ -4432,13 +4426,7 @@ func (s *server) peerConnected(conn net.Conn, connReq *connmgr.ConnReq,
AuxTrafficShaper: s.implCfg.TrafficShaper,
AuxChannelNegotiator: s.implCfg.AuxChannelNegotiator,
ShouldFwdExpAccountability: func() bool {
if s.cfg.ProtocolOptions.NoExpAccountability() {
return false
}

return clock.NewDefaultClock().Now().Before(
AccountabilityExperimentEnd,
)
return !s.cfg.ProtocolOptions.NoExpAccountability()
},
NoDisconnectOnPongFailure: s.cfg.NoDisconnectOnPongFailure,
}
Expand Down
Loading