Skip to content

Conversation

@MPins
Copy link
Contributor

@MPins MPins commented Dec 5, 2025

Release notes warning the users that the deprecated fee rate option --sat_per_byte will be removed in release version 0.22

@gemini-code-assist
Copy link

Summary of Changes

Hello @MPins, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the release notes for version 0.21.0 to proactively inform users about the upcoming removal of the --sat_per_byte fee rate option in the subsequent major release, version 0.22. The update details which RPC commands will be affected, ensuring users are well-prepared for the change.

Highlights

  • Deprecation Warning Added: A new warning has been added to the release notes for version 0.21.0.
  • Fee Rate Option Removal: The warning explicitly states that the deprecated --sat_per_byte fee rate option will be removed in release version 0.22.
  • Impacted RPCs Listed: The release notes now list the specific RPCs that will be impacted by this removal, including sendcoins, sendmany, openchannel, closechannel, closeallchannels, and wallet bumpfee.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a deprecation warning to the release notes for v0.21.0 regarding the removal of the --sat_per_byte option in v0.22. The change is correct in substance, but I have a suggestion to improve the wording for clarity.

@MPins MPins force-pushed the sat_per_byte_remove_warning branch 2 times, most recently from 5f6bf19 to a989a86 Compare December 7, 2025 17:37
@saubyk saubyk added this to v0.21 Dec 8, 2025
@saubyk saubyk moved this to In progress in v0.21 Dec 8, 2025
@MPins MPins force-pushed the sat_per_byte_remove_warning branch from a989a86 to c06d1e8 Compare December 8, 2025 17:27
@MPins MPins requested a review from yyforyongyu December 8, 2025 17:29
Warning message about removing the deprecated option --sat_per_byte
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MPins MPins requested a review from ziggie1984 December 9, 2025 11:48
Copy link
Collaborator

@ziggie1984 ziggie1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roasbeef Roasbeef merged commit 456d7dc into lightningnetwork:master Dec 10, 2025
38 of 41 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in v0.21 Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants