Skip to content

Conversation

@karlseguin
Copy link
Collaborator

@krichprollsch
Copy link
Member

Something is wrong we you already have a v8 dir:

$ make get-v8
Getting v8 source...

v8/src/ already exists, only cloning dependencies

dependency src/build already exists, skipping

dependency src/third_party/jinja2 already exists, skipping

dependency src/buildtools already exists, skipping

dependency src/tools/clang already exists, skipping

dependency src/third_party/zlib already exists, skipping

dependency src/third_party/googletest/src already exists, skipping

dependency src/third_party/markupsafe already exists, skipping

dependency src/third_party/icu already exists, skipping

dependency src/third_party/abseil-cpp already exists, skipping

dependency src/third_party/simdutf already exists, skipping

dependency src/third_party/highway/src/ already exists, skipping

dependency src/third_party/libc++/src already exists, skipping

dependency src/third_party/libc++abi/src already exists, skipping

dependency src/third_party/llvm-libc/src already exists, skipping

dependency src/third_party/fp16/src already exists, skipping

dependency src/third_party/fast_float/src already exists, skipping
Traceback (most recent call last):
  File "/home/pierre/wrk/browser-review/v8/deps_get.py", line 16, in <module>
    main()
  File "/home/pierre/wrk/browser-review/v8/deps_get.py", line 9, in main
    entry = lookup[sys.argv[2]];
            ~~~~~~^^^^^^^^^^^^^
KeyError: 'third_party/dragonbox/src'
get-v8
└─ run exe get-v8
   └─ compile exe get-v8 Debug native
      └─ run /bin/bash failure
error: the following command exited with error code 1:
cd v8 && /bin/bash get_v8.sh

Build Summary: 3/7 steps succeeded; 1 failed
get-v8 transitive failure
└─ run exe get-v8 transitive failure
   └─ compile exe get-v8 Debug native transitive failure
      └─ run /bin/bash failure

error: the following build command failed with exit code 1:
.zig-cache/o/44e287c6e8f30cf5a7a48d6b7ac1e4bb/build /usr/local/zig-0.15.1/zig /usr/local/zig-0.15.1/lib /home/pierre/wrk/browser-review .zig-cache /home/pierre/.cache/zig --seed 0x9926972f -Z33906a4a82e701a2 get-v8
make: *** [Makefile:111: get-v8] Error 1

@krichprollsch
Copy link
Member

Tested with the last version of lightpanda-io/zig-v8-fork#93
It works for me 👍

@karlseguin karlseguin merged commit 6d3065c into main Sep 12, 2025
10 checks passed
@karlseguin karlseguin deleted the upgrade_v8 branch September 12, 2025 00:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants