Limit serve timeout to 1 week #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main.zig
Outdated
|
|
||
| server.run(address, opts.timeout * 1000) catch |err| { | ||
| // max timeout of 1 week. | ||
| const timeout = if (opts.timeout > 604_800) 604_800_000 else @as(i32, @intCast(opts.timeout)) * 1000; |
Member
There was a problem hiding this comment.
We should to either:
- add in the help the indication we take a max of 1 week timeout
- error the command if the value is bigger than 1 week.
Member
There was a problem hiding this comment.
Isn't @as(i32, opts.timeout) enough? why do we need @intCast?
Collaborator
Author
There was a problem hiding this comment.
I expanded on the --help text. I removed the @intcast
krichprollsch
approved these changes
Sep 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.