Convert more DOM_NO_ERR cases to assertions #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some risk to this change. The first is that I made a mistake. The other is that one of the APIs that doesn't currently return an error changes in the future.
krichprollsch
approved these changes
Sep 18, 2025
Member
krichprollsch
left a comment
krichprollsch
left a comment
There was a problem hiding this comment.
2 non-blocking comments
| return parser.nodeGetPrefix(parser.attributeToNode(self)); | ||
| } | ||
|
|
||
| pub fn get_localName(self: *parser.Attribute) ![]const u8 { |
Member
There was a problem hiding this comment.
you don't remove the error return here on purpose? (same for the 2 following)
Collaborator
Author
There was a problem hiding this comment.
The underlying netsurf function still returns an error, I just removed the redundant try.
| const Browser = @import("browser/browser.zig").Browser; | ||
|
|
||
| const build_config = @import("build_config"); | ||
| const parser = @import("browser/netsurf.zig"); |
Member
There was a problem hiding this comment.
Do you use something auto to cleanup imports? or it's manual?
Collaborator
Author
There was a problem hiding this comment.
I used https://github.com/DonIsaac/zlint I was hoping it would help me find error return types that didn't need to be, but it doesn't detect that I guess. And I couldn't help myself but also remove these imports when I saw it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some risk to this change. The first is that I made a mistake. The other is that one of the APIs that doesn't currently return an error changes in the future.