Remove all inlines #1061
Merged
Remove all inlines #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
force-pushed
the
remove_inline
branch
2 times, most recently
from
0ddbc44 to
4c786c9
Compare
Following Zig recommendation not to inline except in specific cases, none of which I think applies to use. Also, mimalloc.create can't fail (it used to be possible, but that changed a while ago), so removed its error return.
karlseguin
force-pushed
the
remove_inline
branch
from
4c786c9 to
9d2948f
Compare
krichprollsch
approved these changes
Sep 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Zig recommendation not to inline except in specific cases, none of which I think applies to use.
Also, mimalloc.create can't fail (it used to be possible, but that changed a while ago), so removed its error return.