Skip to content

Conversation

@nikneym
Copy link
Contributor

@nikneym nikneym commented Sep 18, 2025

Removes error return in postMessage, we still missing the implementation for transfer & options but function seem to work for other cases.

@krichprollsch
Copy link
Member

krichprollsch commented Sep 18, 2025

What about checking if transfer is given to return error only in this case?
I think it's easier to have an error (+log) knowing we don't support something.

@karlseguin
Copy link
Collaborator

karlseguin commented Sep 18, 2025

We think this is for transfer an object to a different JS context. A frame (what I saw) or a web worker.

If the script does:

port.postMessage(null, [object_to_transfer]);
// we should continue to execute code

I don't think it's worth stopping execution (at that point anyways) because the "transfer" to a frame/webworker failed.

@krichprollsch krichprollsch merged commit 516a783 into main Sep 19, 2025
10 checks passed
@krichprollsch krichprollsch deleted the nikneym/relaxed-post-message branch September 19, 2025 09:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants