cdp: implement Security.setIgnoreCertificateErrors #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
cdp-security-ignore-cert-err
branch
from
810b04d to
d2065f7
Compare
Collaborator
|
I don't think it's safe...except for the fact that CDP generally does all of its setup before navigating to the page. You could check if |
Member
Author
|
PR updated |
karlseguin
approved these changes
Oct 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation with #1160
I assume I can change
CURLOPT_SSL_VERIFYHOST,CURLOPT_SSL_VERIFYPEER,CURLOPT_PROXY_SSL_VERIFYHOSTandCURLOPT_PROXY_SSL_VERIFYPEERwith active connections. Not sure if it's safe 🤔