cdp: add AXTree #1308
cdp: add AXTree #1308
Conversation
krichprollsch
force-pushed
the
axtree-backport
branch
from
bbaa33c to
e20ad0c
Compare
| if (value.value) |v| { | ||
| try w.objectField("value"); | ||
| switch (v) { | ||
| .uint => try w.write(v.uint), |
There was a problem hiding this comment.
I think this would work:
switch (v) {
inline else => |v| v try w.write(v),
}| fn toJSON(self: *const Writer, node: *const Node, w: anytype) !void { | ||
| try w.beginArray(); | ||
| const root = try AXNode.fromNode(node.dom); | ||
| if (try self.writeNode(node.id, root, w)) { |
There was a problem hiding this comment.
I would probably reverse this, so that writeNode returns true if the children should be written, so that you can just do:
if (try self.writeNode(node.id, root, w)) {
try self.writeNodeChildren(root, w);
}
return w.endArray();| dom: *DOMNode, | ||
| role_attr: ?[]const u8, | ||
|
|
||
| pub fn fromNode(dom: *DOMNode) !AXNode { |
There was a problem hiding this comment.
This can't return an error. If you remove the error union here, then you can remove it from isIgnore
| switch (dom_node._type) { | ||
| .document => |document| { | ||
| const uri = document.getURL(page); | ||
| try self.writeAXProperty(.{ .name = .url, .value = .{ .type = .string, .value = .{ .string = uri } } }, w); |
There was a problem hiding this comment.
Isn't the type field and union a redundant? Could you make it work with:
.{ .name = .url, .value = .{.string = uri } }And use the std.meta.activeTag(value) in writeAXValue ? (renaming the uint tag to integer)
| } | ||
|
|
||
| fn isHidden(elt: *DOMNode.Element) bool { | ||
| if (elt.getAttributeSafe("aria-hidden")) |value| { |
There was a problem hiding this comment.
Outside this PR, we could potentially optimize checking/fetching multiple attributes. (I think there's a number of small optimizations we might be able to do for attributes, and this multi-attribute check use-case is worth thinking about)
Backport of #1244 for
zigdomfixes #1220
relates with #1217