Skip to content

CDP basic #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 117 commits into from
Oct 17, 2024
Merged

CDP basic #215

merged 117 commits into from
Oct 17, 2024

Conversation

@francisbouvier
Copy link
Member

@francisbouvier francisbouvier commented Apr 16, 2024

No description provided.

@francisbouvier
WIP: CDP
c57bb9e 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Remove alloc from CmdContext struct
babac69 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Free msg at the right place
defab0c 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Working sendLater (I/O timeout)
cfd6fc9 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Handle concurrent calls to sendLater
95a64b7 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Use send as normal behavior in cmdCallback
e908cb0 
+ add nanoseconds param in sendLater

Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add stringify function in cdp
ffbfd36 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
send Target.attachedToTarget after Target.setAutoAttach
5e1fe65 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Big refacto
9805710 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Page domain
b124220 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Page.getFrameTree
a708a7f 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Log domain
626fae0 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Runtime domain
e073e33 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Page.setLifecycleEventsEnabled
0a03dcb 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Page.addScriptToEvaluateOnNewDocument
86b1c85 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Emulation domain
aff2250 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Network domain
67bbd99 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier francisbouvier marked this pull request as draft April 16, 2024 08:15
@francisbouvier
Handle several JSON msg in 1 read
211fa3d 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add setFocusEmulationEnabled
26eda90 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add Runtime.runIfWaitingForDebugger
36dbc28 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Allow method with sessionId and use it when appropriate (*.enable)
9e8b765 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Change Page.addScriptToEvaluateOnNewDocument
05c5d06 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Do not emit optional null value in JSON output
21afa1f 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Handle sessionId in result
4d8cdc6 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Return a result in Page.getFrameTree
e59fc90 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Return sessionId in Emulation.setFocusEmulationEnabled
1620138 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add some optional params in methods
e4ae2df 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Make getParams return nullable
43a558f 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Add method cdp function
490eb40 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
cdp: ensure method action is present
eaf5c6f 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
browser: rename setInspector -> initInspector
fa4920b 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
browser: panic if callInspector without Inspector
28593d9 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
browser: add comment for auxData param in page.navigate
e53b9d9 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
msg: return error if input does not have "size:"
17c6418 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
cdp: fix a comment on page.navigate
7ad03fb 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
cdp: add comment on hard coded ID for page.createIsolatedWorld
4b495f2 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
msg: improve comments on reallocation
fd6c25d 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
msg: set a hard limit max size
ec68059 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
server: panic if sendInspector without an inspector
cbf6348 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
browser: put back VM is an arg for browser init
efca715 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
Remove heap allocation for Session
ea9af21 
And adapt to similar changes on zig-js-runtime for Env

Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
msg: Add a more complex test case with 2 multipart messages combined
7750956 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier
cdp: ensure there is an ID on each request
84c49fb 
Signed-off-by: Francis Bouvier <[email protected]>
krichprollsch
krichprollsch reviewed Oct 15, 2024
View reviewed changes
@francisbouvier
server, cdp: improve logging
8e05f09 
Signed-off-by: Francis Bouvier <[email protected]>
krichprollsch
krichprollsch reviewed Oct 16, 2024
View reviewed changes
@krichprollsch
Copy link
Member

krichprollsch commented Oct 16, 2024

You didn't update the deps with zig-jsruntime isn't it?

@francisbouvier
ci: force ubuntu version (24.04)
8d83dfa 
Signed-off-by: Francis Bouvier <[email protected]>
@francisbouvier francisbouvier merged commit 62ec936 into main Oct 17, 2024
7 checks passed
@krichprollsch krichprollsch deleted the cdp_basic branch October 17, 2024 09:05
@francisbouvier francisbouvier mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krichprollsch krichprollsch krichprollsch left review comments

Assignees

No one assigned

Labels

CDP Chrome Debug Protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francisbouvier @krichprollsch