Skip to content

Conversation

@karlseguin
Copy link
Collaborator

@karlseguin karlseguin commented Feb 25, 2025

Sends basic usage telemetry. Final URL will need to be changed (probably).

Added Telemetry section to readme (please review). And I the Privacy Policy (linked from the readme) might need updating to reflect this collection?

Currently, most things need an Allocator and Loop to run. Now we also need a Telemetry, and it isn't hard to imagine a not-so-distant future where various parts also need access to a Config. Rather than adding more and more parameters, I've introduced an App which is meant to group global data into a single variable, so that future additions are less likely to require touching so much code. Besides this change, the Telemetry code is relatively standalone.

@karlseguin
Copy link
Collaborator Author

Another good reason to replace std.http.Client is just how impossible it is to test.

@karlseguin karlseguin force-pushed the telemetry branch 2 times, most recently from e8340a7 to cc13044 Compare March 5, 2025 02:31
@karlseguin karlseguin changed the title [WIP] Initial usage telemetry Add Usage Telemetry Mar 5, 2025
@krichprollsch
Copy link
Member

krichprollsch commented Mar 17, 2025

@karlseguin after discussion, here is what we could add for the navigate event:

{
  "iid": "ffffffff-ffff-ffff-ffff-ffffffffffff",
  "version": "7b0e725",
  "arch": "x86_64",
  "os": "linux",
  "mode": "serve",
  "driver": "cdp",
  "event": "navigate"

  "tls": true,
  "proxy": false, // is a proxy configured for the request, always false for now.
}

@krichprollsch krichprollsch merged commit 4a4d9a9 into lightpanda-io:main Mar 18, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2025
@karlseguin karlseguin deleted the telemetry branch March 21, 2025 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants