Skip to content

don't generate debug js file on release #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

don't generate debug js file on release #465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a0b154
cdp: dump runtime js only in debug mode
krichprollsch Mar 14, 2025
aca01d8
cdp: use `.zig-cache` to save js script debug files
krichprollsch Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/cdp/runtime.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.

const builtin = @import("builtin");
const std = @import("std");
const cdp = @import("cdp.zig");

Expand All @@ -37,7 +38,7 @@ pub fn processMessage(cmd: anytype) !void {

fn sendInspector(cmd: anytype, action: anytype) !void {
// save script in file at debug mode
if (std.log.defaultLogEnabled(.debug)) {
if (builtin.mode == .Debug) {
try logInspector(cmd, action);
}

Expand Down Expand Up @@ -108,7 +109,7 @@ fn logInspector(cmd: anytype, action: anytype) !void {
const id = cmd.input.id orelse return error.RequiredId;
const name = try std.fmt.allocPrint(cmd.arena, "id_{d}.js", .{id});

var dir = try std.fs.cwd().makeOpenPath("zig-cache/tmp", .{});
var dir = try std.fs.cwd().makeOpenPath(".zig-cache/tmp", .{});
defer dir.close();

const f = try dir.createFile(name, .{});
Expand Down