Skip to content

send telemetry events in batches (up to 20) #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged

send telemetry events in batches (up to 20) #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions src/telemetry/lightpanda.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const telemetry = @import("telemetry.zig");

const log = std.log.scoped(.telemetry);
const URL = "https://telemetry.lightpanda.io";
const MAX_BATCH_SIZE = 20;
Copy link
Member

@krichprollsch krichprollsch Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could safely use a bigger batch, let say 100.


pub const LightPanda = struct {
uri: std.Uri,
Expand Down Expand Up @@ -73,18 +74,18 @@ pub const LightPanda = struct {
fn run(self: *LightPanda) void {
const client = self.client;
var arr: std.ArrayListUnmanaged(u8) = .{};

defer arr.deinit(self.allocator);

var batch: [MAX_BATCH_SIZE]LightPandaEvent = undefined;
self.mutex.lock();
while (true) {
while (self.pending.popFirst()) |node| {
while (self.pending.first != null) {
const b = self.collectBatch(&batch);
self.mutex.unlock();
self.postEvent(&node.data, client, &arr) catch |err| {
self.postEvent(b, client, &arr) catch |err| {
log.warn("Telementry reporting error: {}", .{err});
};
self.mutex.lock();
self.node_pool.destroy(node);
}
if (self.running == false) {
return;
Expand All @@ -93,9 +94,13 @@ pub const LightPanda = struct {
}
}

fn postEvent(self: *const LightPanda, event: *const LightPandaEvent, client: *std.http.Client, arr: *std.ArrayListUnmanaged(u8)) !void {
fn postEvent(self: *const LightPanda, events: []LightPandaEvent, client: *std.http.Client, arr: *std.ArrayListUnmanaged(u8)) !void {
defer arr.clearRetainingCapacity();
try std.json.stringify(event, .{ .emit_null_optional_fields = false }, arr.writer(self.allocator));
var writer = arr.writer(self.allocator);
for (events) |event| {
try std.json.stringify(event, .{ .emit_null_optional_fields = false }, writer);
try writer.writeByte('\n');
}

var response_header_buffer: [2048]u8 = undefined;
const result = try client.fetch(.{
Expand All @@ -109,6 +114,21 @@ pub const LightPanda = struct {
log.warn("server error status: {}", .{result.status});
}
}

fn collectBatch(self: *LightPanda, into: []LightPandaEvent) []LightPandaEvent {
var i: usize = 0;
const node_pool = &self.node_pool;
while (self.pending.popFirst()) |node| {
into[i] = node.data;
node_pool.destroy(node);

i += 1;
if (i == MAX_BATCH_SIZE) {
break;
}
}
return into[0..i];
}
};

const LightPandaEvent = struct {
Expand Down