Enable caller to decide where App lives #496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Mar 28, 2025
| }), | ||
| }; | ||
| app.telemetry = Telemetry.init(app, config.run_mode); | ||
| app.telemetry = Telemetry.init(&app, config.run_mode); |
Collaborator
There was a problem hiding this comment.
This is taking a stack address. It could be ok, depending on what Telemetry does with the app, but in this case, it isn't.
The alternative to doing what I did is to have init take app *App, which achieves what you want: allowing the caller to decide where the app lives. Just a slightly less friendly API and, in many cases, just puts the heap allocation burden on the caller.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before App.init would allocate it self on the heap (allocator).
However there appears to be no reason for it not to live on the stack.
This way the caller get's to decide.