Skip to content

feat: update Dockerfile&add github action #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

feat: update Dockerfile&add github action #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82b6f64
fix: update Dockerfile for new workflow
ryoppippi Apr 18, 2025
c22e963
fix: multi stage build
ryoppippi Apr 18, 2025
0888471
ci: setup docker image build ci
ryoppippi Apr 18, 2025
c8d97ba
fix: use copy instead of clone
ryoppippi Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@

name: Build Docker Image

on:
push:
pull_request:

jobs:
build:
strategy:
matrix:
include:
- runner: ubuntu-24.04
platform: linux/amd64
arch: amd64
- runner: ubuntu-24.04-arm
platform: linux/arm64
arch: arm64
runs-on: ${{ matrix.runner }}
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
submodules: recursive
fetch-depth: 0

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3


- name: Build Docker image for ${{ matrix.arch }}
uses: docker/build-push-action@v5
with:
context: .
file: ./Dockerfile
platforms: ${{ matrix.platform }}
push: false
tags: your-image-name:${{ matrix.arch }}-${{ github.sha }},your-image-name:${{ matrix.arch }}-latest
cache-from: type=gha
cache-to: type=gha,mode=max


161 changes: 111 additions & 50 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,78 +1,139 @@
FROM ubuntu:24.04
# TARGETARCH is a built-in argument provided by Docker, representing the target architecture (e.g., amd64, arm64)
# https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope

ARG MINISIG=0.12
ARG ZIG=0.14.0
ARG ZIG_MINISIG=RWSGOq2NVecA2UPNdBUZykf1CCb147pkmdtYxgb3Ti+JO/wCYvhbAb/U
ARG ARCH=x86_64
ARG V8=11.1.134
ARG ZIG_V8=v0.1.16
ARG ZIG_V8=v0.1.17

RUN apt-get update -yq && \
apt-get install -yq xz-utils \
python3 ca-certificates git \
pkg-config libglib2.0-dev \
gperf libexpat1-dev \
cmake clang \
curl git
# Define the base image alias
FROM ubuntu:24.04 AS base

# install minisig
RUN curl --fail -L -O https://github.com/jedisct1/minisign/releases/download/${MINISIG}/minisign-${MINISIG}-linux.tar.gz && \
tar xvzf minisign-${MINISIG}-linux.tar.gz
# Stage 1: Clone source code
FROM base AS source

# install zig
RUN curl --fail -L -O https://ziglang.org/download/${ZIG}/zig-linux-${ARCH}-${ZIG}.tar.xz
RUN curl --fail -L -O https://ziglang.org/download/${ZIG}/zig-linux-${ARCH}-${ZIG}.tar.xz.minisig

RUN minisign-linux/${ARCH}/minisign -Vm zig-linux-${ARCH}-${ZIG}.tar.xz -P ${ZIG_MINISIG}

# clean minisg
RUN rm -fr minisign-0.11-linux.tar.gz minisign-linux

# install zig
RUN tar xvf zig-linux-${ARCH}-${ZIG}.tar.xz && \
mv zig-linux-${ARCH}-${ZIG} /usr/local/lib && \
ln -s /usr/local/lib/zig-linux-${ARCH}-${ZIG}/zig /usr/local/bin/zig

# clean up zig install
RUN rm -fr zig-linux-${ARCH}-${ZIG}.tar.xz zig-linux-${ARCH}-${ZIG}.tar.xz.minisig
# Install dependencies for this stage
RUN apt-get update -yq && \
apt-get install -yq --no-install-recommends git ca-certificates

# force use of http instead of ssh with github
RUN cat <<EOF > /root/.gitconfig
[url "https://github.com/"]
insteadOf="[email protected]:"
EOF

# clone lightpanda
RUN git clone [email protected]:lightpanda-io/browser.git

COPY . /browser
WORKDIR /browser
RUN git submodule update --init --recursive

# install deps
RUN git submodule init && \
git submodule update --recursive
# Stage 2: Download V8
FROM base AS v8_download

RUN cd vendor/zig-js-runtime && \
git submodule init && \
git submodule update --recursive
ARG V8
ARG ZIG_V8
ARG TARGETARCH # Declare TARGETARCH to use it in this stage

RUN make install-libiconv && \
make install-netsurf && \
make install-mimalloc
# Install dependencies needed for this stage
RUN apt-get update -yq && \
apt-get install -yq --no-install-recommends curl ca-certificates

# Map TARGETARCH for V8 download paths
RUN case ${TARGETARCH} in \
amd64) MAPPED_ARCH=x86_64 ;; \
arm64) MAPPED_ARCH=aarch64 ;; \
*) MAPPED_ARCH=${TARGETARCH} ;; \
esac && \
echo "Using V8 download architecture: ${MAPPED_ARCH} based on TARGETARCH: ${TARGETARCH}" && \
# Download V8 using mapped arch
curl --fail -L -o /libc_v8.a https://github.com/lightpanda-io/zig-v8-fork/releases/download/${ZIG_V8}/libc_v8_${V8}_linux_${MAPPED_ARCH}.a

# Stage 3: Download Zig and Minisign
FROM base AS zig_download

ARG MINISIG
ARG ZIG
ARG ZIG_MINISIG
ARG TARGETARCH # Declare TARGETARCH to use it in this stage

# Install dependencies needed for Zig and Minisign install
RUN apt-get update -yq && \
apt-get install -yq --no-install-recommends curl xz-utils ca-certificates

# Install Minisign and Zig
RUN case ${TARGETARCH} in \
amd64) MAPPED_ARCH=x86_64 ;; \
arm64) MAPPED_ARCH=aarch64 ;; \
*) MAPPED_ARCH=${TARGETARCH} ;; \
esac && \
echo "Using mapped architecture: ${MAPPED_ARCH} based on TARGETARCH: ${TARGETARCH}" && \
# install minisig
curl --fail -L -O https://github.com/jedisct1/minisign/releases/download/${MINISIG}/minisign-${MINISIG}-linux.tar.gz && \
tar xvzf minisign-${MINISIG}-linux.tar.gz && \
mv minisign-linux/${MAPPED_ARCH}/minisign /usr/local/bin/minisign && \
rm -fr minisign-${MINISIG}-linux.tar.gz minisign-linux && \
# install zig using mapped arch (MAPPED_ARCH)
curl --fail -L -O https://ziglang.org/download/${ZIG}/zig-linux-${MAPPED_ARCH}-${ZIG}.tar.xz && \
curl --fail -L -O https://ziglang.org/download/${ZIG}/zig-linux-${MAPPED_ARCH}-${ZIG}.tar.xz.minisig && \
minisign -Vm zig-linux-${MAPPED_ARCH}-${ZIG}.tar.xz -P ${ZIG_MINISIG} && \
tar xvf zig-linux-${MAPPED_ARCH}-${ZIG}.tar.xz && \
mv zig-linux-${MAPPED_ARCH}-${ZIG} /zig

# Stage 4: Build stage
FROM base AS builder

ARG TARGETARCH # Declare TARGETARCH to use it in this stage

# Install build dependencies (removed xz-utils, kept curl for potential other uses)
RUN apt-get update -yq && \
apt-get install -yq \
python3 ca-certificates git \
pkg-config libglib2.0-dev \
gperf libexpat1-dev \
cmake clang \
curl git

# download and install v8
RUN curl --fail -L -o libc_v8.a https://github.com/lightpanda-io/zig-v8-fork/releases/download/${ZIG_V8}/libc_v8_${V8}_linux_${ARCH}.a && \
mkdir -p v8/build/${ARCH}-linux/release/ninja/obj/zig/ && \
mv libc_v8.a v8/build/${ARCH}-linux/release/ninja/obj/zig/libc_v8.a
# Copy installed Zig from the zig_download stage
COPY --from=zig_download /zig /usr/local/lib/zig
# Create the symlink in the builder stage
RUN ln -s /usr/local/lib/zig/zig /usr/local/bin/zig

# build release
RUN make build
# Copy source code
COPY --from=source /browser /browser
COPY --from=source /root/.gitconfig /root/.gitconfig

WORKDIR /browser

FROM ubuntu:24.04
# Install build dependencies from source
RUN make install-libiconv
RUN make install-netsurf
RUN make install-mimalloc
Comment on lines +108 to +110
Copy link
Author

@ryoppippi ryoppippi Apr 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separated the make commands because we can use build cache in each command.
We use multi-stage build so we don't have to worry about the final image size


# Place V8 library using mapped arch names for build system paths
COPY --from=v8_download /libc_v8.a /libc_v8.a
RUN case ${TARGETARCH} in \
amd64) MAPPED_V8_BUILD_ARCH=x86_64 ;; \
arm64) MAPPED_V8_BUILD_ARCH=aarch64 ;; \
*) MAPPED_V8_BUILD_ARCH=${TARGETARCH} ;; \
esac && \
echo "Using V8 build architecture path: ${MAPPED_V8_BUILD_ARCH} based on TARGETARCH: ${TARGETARCH}" && \
mkdir -p v8/build/${MAPPED_V8_BUILD_ARCH}-linux/release/ninja/obj/zig/ && \
mkdir -p v8/build/${MAPPED_V8_BUILD_ARCH}-linux/debug/ninja/obj/zig/ && \
cp /libc_v8.a v8/build/${MAPPED_V8_BUILD_ARCH}-linux/release/ninja/obj/zig/libc_v8.a && \
cp /libc_v8.a v8/build/${MAPPED_V8_BUILD_ARCH}-linux/debug/ninja/obj/zig/libc_v8.a

# Build release
# Ensure git context is available for rev-parse
RUN zig build --release=safe -Doptimize=ReleaseSafe -Dgit_commit=$(git rev-parse --short HEAD)
Copy link
Author

@ryoppippi ryoppippi Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to fix Makefile later actually...
I copy-n-pasted it from build.yml


# Stage 5: Final runtime stage
FROM base

# copy ca certificates
COPY --from=0 /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt

COPY --from=0 /browser/zig-out/bin/lightpanda /bin/lightpanda
# copy application binary
COPY --from=builder /browser/zig-out/bin/lightpanda /bin/lightpanda

EXPOSE 9222/tcp

Expand Down
Loading