Isolated world #554
Isolated world #554
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
sjorsdonkers
force-pushed
the
describeNode2
branch
from
15a5956 to
a698ff8
Compare
sjorsdonkers
force-pushed
the
new_isolated_world
branch
2 times, most recently
from
42e38fe to
de6bb18
Compare
| // constructor/FunctionTemplate as normal, but also through the default | ||
| // FunctionTemplate of the isolate (in startExecutor) | ||
| fn attachClass(self: *Self, comptime Struct: type, template: v8.FunctionTemplate) void { | ||
| fn attachClass(self: *const Self, comptime Struct: type, template: v8.FunctionTemplate) void { |
There was a problem hiding this comment.
Looks like these functions should not be part of the struct
| }; | ||
|
|
||
| const Executor = struct {}; | ||
| const Env = struct { |
There was a problem hiding this comment.
These generic CDPT interfaces seem to give us very little for the amount of complexity they introduce
There was a problem hiding this comment.
Might be possible to partially remove now and load the entire real env. Would probably still be a generic over the client though.
| name: []const u8, | ||
| grant_universal_access: bool, |
There was a problem hiding this comment.
We do not necessarily need to store these as they are not used at the moment.
Alternatively we could consider moving them into Executor as I expect that to merge towards being a Generic World type
| if (comptime builtin.mode == .Debug) { | ||
| std.debug.assert(self.has_executor == false); | ||
| self.has_executor = true; | ||
| if (kind == .main) { |
There was a problem hiding this comment.
In main, the debug has_executor check has been removed to accommodate this PR. With it removed, you should be able to remove kind.
There was a problem hiding this comment.
When getting to this statement myself I initially thought about removing it as well, however I found I could also simplify the opening and closing of the context with it. The I also thought it would just be good metadata to have, so I'd prefer keeping it regardless.
|
@sjorsdonkers can you upgrade the |
sjorsdonkers
force-pushed
the
new_isolated_world
branch
from
43f9526 to
8a9064b
Compare
Depends on: lightpanda-io/zig-v8-fork#57
Create an actually execution Context for Javascript to be executed in separately from the main context.