Change the Linux cancel implementation to match MacOS' #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancel on linux was a "real" cancel, but the implementation was unsafe. It took whatever `id` it was given and @ptrfromint'd it. This is problematic since the `id` is user-supplied with virtually no validation. Using the existing MacOS canceled lookup seems both easier and safer than trying to validate the cancellation id.
krichprollsch
approved these changes
May 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cancel on linux was a "real" cancel, but the implementation was unsafe. It took whatever
idit was given and @ptrfromint'd it. This is problematic since theidis user-supplied with virtually no validation.Using the existing MacOS canceled lookup seems both easier and safer than trying to validate the cancellation id.