Skip to content

Conversation

@karlseguin
Copy link
Collaborator

No description provided.

@krichprollsch
Copy link
Member

Did you use a tool to cleanup the code?

@karlseguin
Copy link
Collaborator Author

Did you use a tool to cleanup the code?

https://github.com/DonIsaac/zlint

Could be integrated in the CI, but it reported the same 2 errors hundreds of times, and I don't really agree. I guess it can be configured. It has a beautiful log output, I'd love to use that log output in browser!

The first warning was it wants a comment whenever undefined is used. I guess after #597 I should think that's a good idea, but we use undefined a lot.

The second was to favor implicit type instead of @as:

const node_base = @as(NodeExternal, @ptrCast(node_aligned));

should be

const node_base: NodeExternal = @ptrCast(node_aligned);

@krichprollsch krichprollsch merged commit 7f2506d into main May 5, 2025
12 checks passed
@krichprollsch krichprollsch deleted the unused_imports branch May 5, 2025 10:07
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants